Remove no-jdk distributions #76896
Merged
Remove no-jdk distributions #76896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-vieira
added
>non-issue
:Delivery/Packaging
|
Pinging @elastic/es-delivery (Team:Delivery) |
|
@elasticmachine run elasticsearch-ci/packaging-tests-windows |
pugnascotia
approved these changes
Aug 25, 2021
breskeby
reviewed
Aug 29, 2021
| } | ||
| } | ||
| currentDistros.add( | ||
| createDistro(distributions, architecture, type, null, bundledJdk, VersionProperties.getElasticsearch()) |
There was a problem hiding this comment.
we can probably remove the bundleJdk parameter from the createDistro
There was a problem hiding this comment.
I purposefully didn't to make backports easier. That might be wishful thinking though.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Apr 8, 2022
The no-jdk distributions exist in 7.x and before. They were removed with 8.0. This commit removes the remaining deprecation messages for using the no-jdk distribution. Note that when talking with an older node, we drop the bundledJdk attribute. This is ok because it is only possible for this to not be true when talking with a 7.17 node, during an upgrade, and the usingBundledJdk is retained, which is the important thing if debugging a problem. relates elastic#76896 relates elastic#85758
rjernst
added a commit
that referenced
this pull request
Apr 11, 2022
The no-jdk distributions exist in 7.x and before. They were removed with 8.0. This commit removes the remaining deprecation messages for using the no-jdk distribution. Note that when talking with an older node, we drop the bundledJdk attribute. This is ok because it is only possible for this to not be true when talking with a 7.17 node, during an upgrade, and the usingBundledJdk is retained, which is the important thing if debugging a problem. relates #76896 relates #85758
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with Elasticsearch 8.0 we will no longer build separate "no-jdk" distributions. All distributions now include by default a bundled JDK and users can configure an alternative JDK distribution via
ES_JAVA_HOME.I've left some references to no-jdk distribution handling code to make future backports easier but all the build scripts under
distribution/have had conditional jdk logic stripped out. Additionally, there was a lot of lingering code related to OSS distributions which no longer exist which has been removed as well and will be separately backported to7.x.Closes #65109