Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only set `breaker` when stats are retrieved #7721

Merged
merged 1 commit into from Sep 15, 2014

Conversation

Projects
None yet
3 participants
@dakrone
Copy link
Member

dakrone commented Sep 15, 2014

When communicating with 1.3 and earlier nodes, it's possible that the
field data breaker info is not sent at all. When this happens, we should
leave the breaker variable as-is (unset) instead of creating an
AllCircuitBreakerStats object with a null fd breaker and fake request &
parent breakers.

@dakrone

This comment has been minimized.

Copy link
Member Author

dakrone commented Sep 15, 2014

Added a BWC test to this.

@s1monw

This comment has been minimized.

Copy link
Contributor

s1monw commented Sep 15, 2014

LGTM

@dakrone dakrone force-pushed the dakrone:fix-breaker-nodes-stats branch 2 times, most recently to 964db64 Sep 15, 2014

Only set `breaker` when stats are retrieved
When communicating with 1.3 and earlier nodes, it's possible that the
field data breaker info is not sent at all. When this happens, we should
leave the `breaker` variable as-is (unset) instead of creating an
AllCircuitBreakerStats object with a null fd breaker and fake request &
parent breakers.

@dakrone dakrone removed the review label Sep 15, 2014

@dakrone dakrone merged commit 964db64 into elastic:master Sep 15, 2014

@dakrone dakrone deleted the dakrone:fix-breaker-nodes-stats branch Sep 15, 2014

@clintongormley clintongormley added the >bug label Sep 26, 2014

@clintongormley clintongormley changed the title Only set `breaker` when stats are retrieved Circuit Breaker: Only set `breaker` when stats are retrieved Sep 26, 2014

@clintongormley clintongormley changed the title Circuit Breaker: Only set `breaker` when stats are retrieved Only set `breaker` when stats are retrieved Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.