Remove use of Joda from test framework #78851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test base class ESTestCase provides methods to get a random timezone. It has methods for Joda, java.time and java.util timezones. This commit reworks the test helper methods to no longer use Joda. Due to backcompat tests for sql, the random timezones need to be limited to those that are still useable by Joda. To filter the available timezones not available in Joda, the unsupported timezone ids are hardcoded in testcase initialization.
rjernst
added
>test
elasticmachine
added
Team:QL (Deprecated)
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
Pinging @elastic/es-ql (Team:QL) |
rjernst
commented
Oct 7, 2021
| } | ||
|
|
||
| /** | ||
| * generate a random TimeZone from the ones available in java.time | ||
| */ | ||
| public static ZoneId randomZone() { | ||
| // work around a JDK bug, where java 8 cannot parse the timezone GMT0 back into a temporal accessor | ||
| // see https://bugs.openjdk.java.net/browse/JDK-8138664 | ||
| if (JavaVersion.current().getVersion().get(0) == 8) { |
There was a problem hiding this comment.
Note this is no longer necessary on master since Java 11 (and soon Java 17) is the minimum runtime version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test base class ESTestCase provides methods to get a random
timezone. It has methods for Joda, java.time and java.util timezones.
This commit reworks the test helper methods to no longer use Joda. Due
to backcompat tests for sql, the random timezones need to be limited to
those that are still useable by Joda. To filter the available timezones
not available in Joda, the unsupported timezone ids are hardcoded in
testcase initialization.