Deprecate lenient parsing of bulk actions #78876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arteam
force-pushed
the
bulk-action-sctrict-parsing
branch
8 times, most recently
from
2f2dc18
to
81b22c3
Compare
arteam
force-pushed
the
bulk-action-sctrict-parsing
branch
4 times, most recently
from
a21de9e
to
f9abffa
Compare
arteam
changed the title
Make sure there are no arbitrary fields after an action declaration and it gets closed by a curly bracket. Add a deprecation warning for strict bulk action parsing
|
Pinging @elastic/es-distributed (Team:Distributed) |
arteam
added
the
:Distributed/CRUD
arteam
changed the title
DaveCTurner
requested changes
Oct 26, 2021
server/src/main/java/org/elasticsearch/action/bulk/BulkRequestParser.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/bulk/BulkRequestParser.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/bulk/BulkRequestParser.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/bulk/BulkRequestParser.java
Outdated
Show resolved
Hide resolved
arteam
force-pushed
the
bulk-action-sctrict-parsing
branch
from
4fff9f6
to
6bbb5bc
Compare
DaveCTurner
reviewed
Nov 1, 2021
server/src/main/java/org/elasticsearch/action/bulk/BulkRequestParser.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/bulk/BulkRequestParser.java
Outdated
Show resolved
Hide resolved
…Parser.java Co-authored-by: David Turner <david.turner@elastic.co>
…Parser.java Co-authored-by: David Turner <david.turner@elastic.co>
|
@elasticmachine update branch |
DaveCTurner
reviewed
Nov 5, 2021
There was a problem hiding this comment.
Code changes all LGTM, but since this adds deprecations I think we need to add docs about the change too. #80410 adds the deprecation docs files for 8.1.0 so you can either wait for that to be merged or else duplicate those files here (and I'll sort out any merge conflicts on my PR later).
|
@elasticmachine update branch |
|
Thanks David! |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Nov 10, 2021
Follow-up to elastic#78876 to rework the deprecation docs slightly.
|
I would have preferred not to have merged this until the docs changes were reviewed and approved - it's hard to keep track of outstanding things to review otherwise. I opened #80580 to suggest alternative wording and revert the unnecessary docs formatting changes that this PR introduces. |
DaveCTurner
added a commit
that referenced
this pull request
Nov 10, 2021
elasticmachine
pushed a commit
to not-napoleon/elasticsearch
that referenced
this pull request
Aug 15, 2022
Adds a mention of `Version.V_7_17_0` so that we don't forget to remove this deprecated behaviour in the next major version. Relates elastic#78876
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure there are no arbitrary fields after an action declaration and that it gets properly closed by a curly bracket.
Resolves #43774