Document how to test a dev version of a 3party dependency #78962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduce a FAQ section to BUILDING.MD - Provide three solutions to test and use a custom third party dependency in our elasticsearch build
breskeby
added
:Delivery/Build
breskeby
requested review from
mark-vieira,
pugnascotia,
DaveCTurner and
joegallo
|
Pinging @elastic/es-delivery (Team:Delivery) |
pugnascotia
reviewed
Oct 12, 2021
pugnascotia
reviewed
Oct 12, 2021
pugnascotia
reviewed
Oct 12, 2021
BUILDING.md
Outdated
| flat directory repositories cannot be used to override artifacts with real meta-data from other repositories declared in the build. | ||
| For example, if Gradle finds only `jmxri-1.2.1.jar` in a flat directory repository, but `jmxri-1.2.1.pom` in another repository | ||
| that supports meta-data, it will use the second repository to provide the module. | ||
| For the use case of overriding remote artifacts with local ones consider using an Ivy or Maven repository instead whose URL points to a local directory. |
There was a problem hiding this comment.
Is it possible to give an example of this?
There was a problem hiding this comment.
I tweaked the recommendation to use a version that is not public available yet. Setting up a manual ivy or maven repository would likely involve handcraft a custom ivy.xml or pom.xml file which is not recommended and likely causes more trouble :)
Co-authored-by: Rory Hunter <pugnascotia@users.noreply.github.com>
Co-authored-by: Rory Hunter <pugnascotia@users.noreply.github.com>
Apply review feedback
pugnascotia
approved these changes
Oct 12, 2021
mark-vieira
approved these changes
Oct 12, 2021
BUILDING.md
Outdated
| } | ||
| ``` | ||
|
|
||
| 3. Update the dependency declaration of the artifact in question to match the custom build version. |
There was a problem hiding this comment.
Should we clarify here what that means? When using a flatDir repo the dependency notation is simply the jar name isn't it?
There was a problem hiding this comment.
I've added some more details about that
breskeby
added
auto-merge
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Oct 13, 2021
) * Document how to test a dev version of a 3party dependency - Introduce a FAQ section to BUILDING.MD - Provide three solutions to test and use a custom third party dependency in our elasticsearch build * Fix jitpack repo declaration * Tweak formatting * Apply review feedback Co-authored-by: Rory Hunter <pugnascotia@users.noreply.github.com> * Apply further review feedback Co-authored-by: Rory Hunter <pugnascotia@users.noreply.github.com> * Tweak recommendations for replacing a dependency Apply review feedback * Elaborate on dependency declaration to resolves jars from flat dir repositories Co-authored-by: Rory Hunter <pugnascotia@users.noreply.github.com>
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 13, 2021
…79040) * Document how to test a dev version of a 3party dependency - Introduce a FAQ section to BUILDING.MD - Provide three solutions to test and use a custom third party dependency in our elasticsearch build * Fix jitpack repo declaration * Tweak formatting * Apply review feedback Co-authored-by: Rory Hunter <pugnascotia@users.noreply.github.com> * Apply further review feedback Co-authored-by: Rory Hunter <pugnascotia@users.noreply.github.com> * Tweak recommendations for replacing a dependency Apply review feedback * Elaborate on dependency declaration to resolves jars from flat dir repositories Co-authored-by: Rory Hunter <pugnascotia@users.noreply.github.com> Co-authored-by: Rory Hunter <pugnascotia@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in our elasticsearch build