Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] deprecate estimated_heap_memory_usage_bytes and replace with model_size_bytes #80554

Conversation

benwtrent
Copy link
Member

This deprecates estimated_heap_memory_usage_bytes on model put and replaces it with model_size_bytes.

On GET, only model_size_bytes is returned unless v7 rest-api compatibility is requested.

For the ml/info API, only model_size_bytes is returned

A forward-port of: #80545

@benwtrent benwtrent added >deprecation :ml Machine learning v8.0.0 auto-backport-and-merge Automatically create backport pull requests and merge when ready v8.1.0 labels Nov 9, 2021
@elasticmachine elasticmachine added the Team:ML Meta label for the ML team label Nov 9, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@benwtrent
Copy link
Member Author

@elasticmachine update branch

@benwtrent benwtrent merged commit 5627dc6 into elastic:master Nov 10, 2021
@benwtrent benwtrent deleted the feature/ml-deprecating-heap-memory-estimation branch November 10, 2021 15:23
benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Nov 10, 2021
…el_size_bytes (elastic#80554)

This deprecates estimated_heap_memory_usage_bytes on model put and replaces it with model_size_bytes.

On GET, only model_size_bytes is returned unless v7 rest-api compatibility is requested.

For the ml/info API, only model_size_bytes is returned

A forward-port of: elastic#80545
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.0

elasticsearchmachine pushed a commit that referenced this pull request Nov 10, 2021
…el_size_bytes (#80554) (#80610)

This deprecates estimated_heap_memory_usage_bytes on model put and replaces it with model_size_bytes.

On GET, only model_size_bytes is returned unless v7 rest-api compatibility is requested.

For the ml/info API, only model_size_bytes is returned

A forward-port of: #80545
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport-and-merge Automatically create backport pull requests and merge when ready >deprecation :ml Machine learning Team:ML Meta label for the ML team v7.16.0 v8.0.0-rc2 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants