-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] deprecate estimated_heap_memory_usage_bytes and replace with model_size_bytes #80554
Merged
benwtrent
merged 8 commits into
elastic:master
from
benwtrent:feature/ml-deprecating-heap-memory-estimation
Nov 10, 2021
Merged
[ML] deprecate estimated_heap_memory_usage_bytes and replace with model_size_bytes #80554
benwtrent
merged 8 commits into
elastic:master
from
benwtrent:feature/ml-deprecating-heap-memory-estimation
Nov 10, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…el_size_bytes fixing tests
Pinging @elastic/ml-core (Team:ML) |
@elasticmachine update branch |
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Nov 10, 2021
…el_size_bytes (elastic#80554) This deprecates estimated_heap_memory_usage_bytes on model put and replaces it with model_size_bytes. On GET, only model_size_bytes is returned unless v7 rest-api compatibility is requested. For the ml/info API, only model_size_bytes is returned A forward-port of: elastic#80545
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 10, 2021
…el_size_bytes (#80554) (#80610) This deprecates estimated_heap_memory_usage_bytes on model put and replaces it with model_size_bytes. On GET, only model_size_bytes is returned unless v7 rest-api compatibility is requested. For the ml/info API, only model_size_bytes is returned A forward-port of: #80545
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport-and-merge
Automatically create backport pull requests and merge when ready
>deprecation
:ml
Machine learning
Team:ML
Meta label for the ML team
v7.16.0
v8.0.0-rc2
v8.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deprecates estimated_heap_memory_usage_bytes on model put and replaces it with model_size_bytes.
On GET, only
model_size_bytes
is returned unless v7 rest-api compatibility is requested.For the ml/info API, only
model_size_bytes
is returnedA forward-port of: #80545