Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stopping of old elasticsearch cluster #81059

Merged

Conversation

breskeby
Copy link
Contributor

due to not exposing the PID of the underlaying cluster the Fixture Stop task
was skipped, leaving running clusters behind after the build finished

due to not exposing the PID of the underlaying cluster the Fixture Stop task
was skipped, leaving running clusters behind after the build finished
@breskeby breskeby self-assigned this Nov 25, 2021
@breskeby breskeby added :Delivery/Build Build or test infrastructure >enhancement auto-backport-and-merge Automatically create backport pull requests and merge when ready auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) Team:Delivery Meta label for Delivery team v7.16.0 v8.1.0 v8.0.0 and removed v8.1.0 labels Nov 25, 2021
@breskeby breskeby marked this pull request as ready for review November 25, 2021 16:20
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

Copy link
Contributor

@mark-vieira mark-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's get this merged.

@breskeby breskeby merged commit c2b6284 into elastic:master Nov 30, 2021
breskeby added a commit to breskeby/elasticsearch that referenced this pull request Nov 30, 2021
due to not exposing the PID of the underlaying cluster the Fixture Stop task
was skipped, leaving running clusters behind after the build finished
breskeby added a commit to breskeby/elasticsearch that referenced this pull request Nov 30, 2021
due to not exposing the PID of the underlaying cluster the Fixture Stop task
was skipped, leaving running clusters behind after the build finished
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.0
7.16

elasticsearchmachine pushed a commit that referenced this pull request Nov 30, 2021
due to not exposing the PID of the underlaying cluster the Fixture Stop task
was skipped, leaving running clusters behind after the build finished
elasticsearchmachine pushed a commit that referenced this pull request Nov 30, 2021
due to not exposing the PID of the underlaying cluster the Fixture Stop task
was skipped, leaving running clusters behind after the build finished
weizijun added a commit to weizijun/elasticsearch that referenced this pull request Nov 30, 2021
* upstream/master:
  [ML] Parent datafeed actions to the datafeed's persistent task (elastic#81143)
  Simplify ConcreteIndices and its usage in TransportBulkAction (elastic#81098)
  Unmute DataStreamsSnapshotsIT#testRestoreDataStreamAliasWithConflictingIndicesAlias() test (elastic#81142)
  TSDB: Do not allow index splits for time series indices (elastic#81125)
  Reduce verbosity-increase timeout to 3m (elastic#81118)
  Mute DataStreamsSnapshotsIT#testRestoreDataStreamAliasWithConflictingIndicesAlias() test
  Fix stopping of old elasticsearch cluster (elastic#81059)
  Fix data stream alias validation. (elastic#81040)
  Add replicated field to get data stream api response. (elastic#80988)
ywangd pushed a commit to ywangd/elasticsearch that referenced this pull request Dec 1, 2021
due to not exposing the PID of the underlaying cluster the Fixture Stop task
was skipped, leaving running clusters behind after the build finished
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport-and-merge Automatically create backport pull requests and merge when ready auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Delivery/Build Build or test infrastructure >enhancement Team:Delivery Meta label for Delivery team v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants