Use leak-tracking recycler in InboundPipelineTests #81065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today we use a leaky `NON_RECYCLING_INSTANCE` in `InboundPipelineTests#testPipelineHandling`. It's actually fine, we don't use it for anything important, but it looks suspicious and it means that a little bit of harmless-looking reordering would seriously affect the coverage of these tests. This commit gets rid of it to ensure that we're always watching for leaks. Noticed when reviewing elastic#80656.
DaveCTurner
added
>non-issue
:Distributed/Network
|
Pinging @elastic/es-distributed (Team:Distributed) |
idegtiarenko
approved these changes
Nov 29, 2021
DaveCTurner
added
the
auto-merge
tlrx
pushed a commit
to tlrx/elasticsearch
that referenced
this pull request
Mar 3, 2022
Today we use a leaky `NON_RECYCLING_INSTANCE` in `InboundPipelineTests#testPipelineHandling`. It's actually fine, we don't use it for anything important, but it looks suspicious and it means that a little bit of harmless-looking reordering would seriously affect the coverage of these tests. This commit gets rid of it to ensure that we're always watching for leaks. Noticed when reviewing elastic#80656.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we use a leaky
NON_RECYCLING_INSTANCEinInboundPipelineTests#testPipelineHandling. It's actually fine, wedon't use it for anything important, but it looks suspicious and it
means that a little bit of harmless-looking reordering would seriously
affect the coverage of these tests. This commit gets rid of it to ensure
that we're always watching for leaks.
Noticed when reviewing #80656.