Make simple_query_string leniency more fine-grained #8162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
Previously, the leniency was on a per-query basis, with each query being parsed into multiple queries, one for each field. If any one of these queries failed, the entire query was discarded in the name of being lenient. Now query parts will only be discarded if they fail for a particular field, the entire query is not discarded. This helps when performing a query over a numeric and string field, as only the sub-queries that are invalid due to format exceptions will be discarded. Also moves the `simple_query_string` queries out of SimpleQueryTests and into a dedicated SimpleQueryStringTests class. Fixes elastic#7967
dakrone
force-pushed
the
sqs-lenient-too-lenient
branch
from
7e17bf9
to
26bc940
Compare
clintongormley
changed the title
clintongormley
changed the title
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the leniency was on a per-query basis, with each query being
parsed into multiple queries, one for each field. If any one of these
queries failed, the entire query was discarded in the name of being
lenient.
Now query parts will only be discarded if they fail for a particular
field, the entire query is not discarded. This helps when performing a
query over a numeric and string field, as only the sub-queries that are
invalid due to format exceptions will be discarded.
Also moves the
simple_query_stringqueries out of SimpleQueryTests andinto a dedicated SimpleQueryStringTests class.
Fixes #7967