Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Transform] Do not align checkpoints for transforms created before 7.15. #81729

Merged
merged 1 commit into from Dec 15, 2021
Merged

[Transform] Do not align checkpoints for transforms created before 7.15. #81729

merged 1 commit into from Dec 15, 2021

Conversation

przemekwitek
Copy link
Contributor

@przemekwitek przemekwitek commented Dec 14, 2021 •
edited

Do not align checkpoints for transforms created before 7.15 i.e. before the align_checkpoints optimization (see #74004) was introduced.

@przemekwitek przemekwitek force-pushed the do_not_align_for_old_transforms branch 3 times, most recently from 39cb8cc to 20380c5 Compare December 14, 2021 14:55
@przemekwitek przemekwitek added v8.0.0 auto-backport-and-merge Automatically create backport pull requests and merge when ready v7.16.0 and removed WIP labels Dec 15, 2021
@przemekwitek przemekwitek marked this pull request as ready for review December 15, 2021 08:52
@elasticmachine elasticmachine added the Team:ML Meta label for the ML team label Dec 15, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

hendrikmuhs
hendrikmuhs approved these changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@hendrikmuhs hendrikmuhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@przemekwitek przemekwitek merged commit d26002a into elastic:master Dec 15, 2021
@przemekwitek przemekwitek deleted the do_not_align_for_old_transforms branch December 15, 2021 11:40
@przemekwitek przemekwitek mentioned this pull request Dec 15, 2021
Merged
przemekwitek added a commit to przemekwitek/elasticsearch that referenced this pull request Dec 15, 2021
@przemekwitek
[Transform] Do not align checkpoints for transforms created before 7.…
e4f7531 
…15. (elastic#81729)
@przemekwitek przemekwitek mentioned this pull request Dec 15, 2021
Merged
przemekwitek added a commit to przemekwitek/elasticsearch that referenced this pull request Dec 15, 2021
@przemekwitek
[Transform] Do not align checkpoints for transforms created before 7.…
0a03efc 
…15. (elastic#81729)
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.0
✅ 7.16

@przemekwitek przemekwitek mentioned this pull request Dec 15, 2021
Merged
elasticsearchmachine pushed a commit that referenced this pull request Dec 15, 2021
@przemekwitek
[8.0] [Transform] Do not align checkpoints for transforms created bef…
01e9e8c 
…ore 7.15. (#81729) (#81753)

* [Transform] Do not align checkpoints for transforms created before 7.15. (#81729)

* Fix NPE in transform version check
elasticsearchmachine pushed a commit that referenced this pull request Dec 15, 2021
@przemekwitek
[7.16] [Transform] Do not align checkpoints for transforms created be…
3724fbe 
…fore 7.15. (#81729) (#81754)

* [Transform] Do not align checkpoints for transforms created before 7.15. (#81729)

* Fix NPE in transform version check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hendrikmuhs hendrikmuhs hendrikmuhs approved these changes

Assignees
No one assigned
Labels
auto-backport-and-merge Automatically create backport pull requests and merge when ready >bug :ml/Transform Transform Team:ML Meta label for the ML team v7.16.0 v8.0.0-rc1 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@przemekwitek @elasticmachine @elasticsearchmachine @hendrikmuhs @mark-vieira