Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PendingReplicationActions Submitting lots of NOOP Tasks to GENERIC #82092

Conversation

original-brownbear
Copy link
Member

@original-brownbear original-brownbear commented Dec 27, 2021

At times sending empty lists to generic here did get quite hot in many shards benchmarks.

extracted from #79837
relates #77466

At times sending empty lists to generic here did get quite hot in many shards benchmarks.
@original-brownbear original-brownbear added >non-issue :Distributed/Recovery Anything around constructing a new shard, either from a local or a remote source. v8.0.0 v8.1.0 labels Dec 27, 2021
@elasticmachine elasticmachine added the Team:Distributed Meta label for distributed team label Dec 27, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@original-brownbear
Copy link
Member Author

Jenkins run elasticsearch-ci/part-2

Copy link
Contributor

@henningandersen henningandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I think we should mark this an enhancement, we expect some positive impact from this.

@original-brownbear original-brownbear added >enhancement auto-backport-and-merge Automatically create backport pull requests and merge when ready and removed >non-issue labels Dec 27, 2021
@original-brownbear
Copy link
Member Author

Thanks Henning!

I think we should mark this an enhancement, we expect some positive impact from this.

++ done

@original-brownbear original-brownbear merged commit 806dfcb into elastic:master Dec 27, 2021
@original-brownbear original-brownbear deleted the speed-up-pending-repl-actions branch December 27, 2021 20:13
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Dec 27, 2021
elastic#82092)

At times sending empty lists to generic here did get quite hot in many shards benchmarks.
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.0

elasticsearchmachine pushed a commit that referenced this pull request Dec 27, 2021
#82092) (#82098)

At times sending empty lists to generic here did get quite hot in many shards benchmarks.
@original-brownbear original-brownbear restored the speed-up-pending-repl-actions branch April 18, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport-and-merge Automatically create backport pull requests and merge when ready :Distributed/Recovery Anything around constructing a new shard, either from a local or a remote source. >enhancement Team:Distributed Meta label for distributed team v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants