Reject zero-length vectors when using cosine similarity #82241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cosine similarity is not defined when one of the vectors has zero magnitude. Before, the kNN search endpoint threw a confusing exception related to top docs collection. Now we reject vectors early with a clear error message, failing indexing if the vector has zero magnitude.
jtibshirani
added
:Search/Search
|
This PR only addressed indexed vectors used in kNN search. For non-indexed vectors, we can't check the magnitude when they're ingested, since we don't know what similarity function will end up being used. During search, the |
|
Pinging @elastic/es-search (Team:Search) |
cbuescher
approved these changes
Jan 11, 2022
jtibshirani
added a commit
to jtibshirani/elasticsearch
that referenced
this pull request
Jan 11, 2022
Cosine similarity is not defined when one of the vectors has zero magnitude. Before, the kNN search endpoint threw a confusing exception related to top docs collection. Now we reject vectors early with a clear error message, failing indexing if the vector has zero magnitude.
jtibshirani
added
:Search/Vectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cosine similarity is not defined when one of the vectors has zero magnitude.
Before, the kNN search endpoint threw a confusing exception related to top docs
collection. Now we reject vectors early with a clear error message, failing
indexing if the vector has zero magnitude.
Closes #81167.