-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add beats_stats.metrics.apm-server.sampling.tail
to stack monitoring templates
#82401
Conversation
Add mappings for apm-server.sampling.tail fields to the monitoring templates.
beats_stats.metrics.apm-server.sampling.tail
to stack monitoring templates
Pinging @elastic/es-data-management (Team:Data Management) |
@elasticmachine update branch |
@axw are these meant to be fields added to the legacy monitoring templates or are these meant to be added to the templates used by stack monitoring? |
@jbaiera both I think? My understanding is that legacy templates are used when libbeat is configured with internal (legacy) monitoring, and the Metricbeat templates are used for the current/recommended Metricbeat approach. |
Hi @axw, I've created a changelog YAML for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apm server supports internal and metricbeat collection methods so both templates have to be updated.
LGTM
Thanks for taking a look @klacabane! @jbaiera if it looks good to you, would you kindly merge so it can make it for 8.1? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay here - we didn't expect there to be any changes landing in the legacy monitoring formats at all going forward as they are expected to be removed. That said, I don't see any major issues at the moment with bumping the last updated version since it's just used for updating the mappings, and nothing has broken between the versions.
It looks like there's still some issues with CI? @elasticmachine update branch |
@elasticmachine run elasticsearch-ci/part-1 |
💔 Backport failedThe backport operation could not be completed due to the following error: You can use sqren/backport to manually backport by running |
@jakelandis how would you feel about backporting this to 8.1? Seems very low risk to me at this early stage. The feature that these metrics are related to is going GA in 8.1, so it would be very helpful for us to be able to query them. |
…g templates (#82401) (#83625) * monitoring: index apm-server.sampling.tail Add mappings for apm-server.sampling.tail fields to the monitoring templates. * Update docs/changelog/82401.yaml Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Add mappings for
beats_stats.metrics.apm-server.sampling.tail
to the monitoring templates.Closes elastic/apm-server#6581