Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add beats_stats.metrics.apm-server.sampling.tail to stack monitoring templates #82401

Merged
merged 6 commits into from
Feb 3, 2022

Conversation

axw
Copy link
Member

@axw axw commented Jan 11, 2022

Add mappings for beats_stats.metrics.apm-server.sampling.tail to the monitoring templates.

Closes elastic/apm-server#6581

Add mappings for apm-server.sampling.tail fields
to the monitoring templates.
@elasticsearchmachine elasticsearchmachine added the external-contributor Pull request authored by a developer outside the Elasticsearch team label Jan 11, 2022
@axw axw changed the title monitoring: index apm-server.sampling.tail Add beats_stats.metrics.apm-server.sampling.tail to stack monitoring templates Jan 11, 2022
@axw axw marked this pull request as ready for review January 11, 2022 07:37
@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Jan 11, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@axw
Copy link
Member Author

axw commented Jan 24, 2022

@elasticmachine update branch

@jbaiera
Copy link
Member

jbaiera commented Jan 25, 2022

@axw are these meant to be fields added to the legacy monitoring templates or are these meant to be added to the templates used by stack monitoring?

@axw
Copy link
Member Author

axw commented Jan 31, 2022

@jbaiera both I think?

My understanding is that legacy templates are used when libbeat is configured with internal (legacy) monitoring, and the Metricbeat templates are used for the current/recommended Metricbeat approach.

@elasticsearchmachine
Copy link
Collaborator

Hi @axw, I've created a changelog YAML for you.

Copy link
Contributor

@klacabane klacabane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apm server supports internal and metricbeat collection methods so both templates have to be updated.
LGTM

@axw
Copy link
Member Author

axw commented Feb 2, 2022

Thanks for taking a look @klacabane!

@jbaiera if it looks good to you, would you kindly merge so it can make it for 8.1?

@mark-vieira mark-vieira added v8.2.0 and removed v8.1.0 labels Feb 2, 2022
Copy link
Member

@jbaiera jbaiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay here - we didn't expect there to be any changes landing in the legacy monitoring formats at all going forward as they are expected to be removed. That said, I don't see any major issues at the moment with bumping the last updated version since it's just used for updating the mappings, and nothing has broken between the versions.

@jbaiera
Copy link
Member

jbaiera commented Feb 2, 2022

It looks like there's still some issues with CI?

@elasticmachine update branch

@axw
Copy link
Member Author

axw commented Feb 3, 2022

@elasticmachine run elasticsearch-ci/part-1

@axw axw merged commit a04d4ff into elastic:master Feb 3, 2022
@axw axw added the auto-backport Automatically create backport pull requests when merged label Feb 3, 2022
@axw axw deleted the beats-monitoring-apmserver branch February 3, 2022 02:10
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

The backport operation could not be completed due to the following error:
There are no branches to backport to. Aborting.

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 82401

@axw axw removed the auto-backport Automatically create backport pull requests when merged label Feb 3, 2022
@axw
Copy link
Member Author

axw commented Feb 3, 2022

@jakelandis how would you feel about backporting this to 8.1? Seems very low risk to me at this early stage. The feature that these metrics are related to is going GA in 8.1, so it would be very helpful for us to be able to query them.

@axw axw added auto-backport Automatically create backport pull requests when merged v8.1.0 auto-backport-and-merge Automatically create backport pull requests and merge when ready labels Feb 8, 2022
axw added a commit that referenced this pull request Feb 8, 2022
…g templates (#82401) (#83625)

* monitoring: index apm-server.sampling.tail

Add mappings for apm-server.sampling.tail fields
to the monitoring templates.

* Update docs/changelog/82401.yaml

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged auto-backport-and-merge Automatically create backport pull requests and merge when ready :Data Management/Monitoring >enhancement external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Data Management Meta label for data/management team v8.1.0 v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monitoring data is not indexed in ES
6 participants