Immediately remove filter cache entries on cache clear #8289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the job is still rescheduled in the event that it was rejected from the threadpool, or an exception occured while cleaning
dakrone
changed the title
| } | ||
| indicesFilterCache.addReaderKeyToClean(readerKey); | ||
| } | ||
| seenReaders.clear(); |
There was a problem hiding this comment.
I wonder if we can get a race here stuff that is in seen readers but not in the cache or so?
There was a problem hiding this comment.
I think we can, going to close this PR until we come up with a better solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had a more complex listing where we added each reader key to the list of keys cleaned intermittently by
IndicesFilterCache.ReaderCleaner.run(), but because every entry is being invalidated due to the cache clear, we should immediately clear them and clean up the cache.This also moves the periodic cleaning rescheduling into a finally block so an exception does not prevent the cleanup from being rescheduled.
Fixes #8285