Always emit product origin to deprecation log if present #83115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, we only emit the product origin to the deprecation log if there's an opaque ID present. This is very counterintuitive, and probably not intentional given that it doesn't match the behavior in `master`. This commit changes the behavior so that the product origin will always be included in the deprecation log JSON if it's present in the context of the request.
gwbrown
added
>bug
:Core/Infra/Logging
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
pgomulka
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, we only emit the product origin to the deprecation log
if there's an opaque ID present. This is very counterintuitive, and probably
not intentional given that it doesn't match the behavior in
master.This commit changes the behavior so that the product origin
will always be included in the deprecation log JSON if it's present in the
context of the request.