Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Returns valid PIT when no index matched #83424

Merged
merged 3 commits into from
Feb 3, 2022
Merged

Returns valid PIT when no index matched #83424

merged 3 commits into from
Feb 3, 2022

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Feb 2, 2022 •
edited
Loading

We should return a valid PIT instead of tripping an assertion when the index wildcard matches no index.

@dnhatn
Returns valid PIT when no index matched
2e829a2 
We should return a valid PIT value instead of tripping an assertion when
the index wildcard matches no index.
@dnhatn dnhatn added >bug :Search/Search Search-related issues that do not fall into other categories v8.1.0 labels Feb 2, 2022
@dnhatn dnhatn requested a review from ywelsch February 2, 2022 19:07
@elasticmachine elasticmachine added the Team:Search Meta label for search team label Feb 2, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@elasticsearchmachine
Copy link
Collaborator

Hi @dnhatn, I've created a changelog YAML for you.

@mark-vieira mark-vieira added v8.2.0 and removed v8.1.0 labels Feb 2, 2022
ywelsch
ywelsch approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnhatn
Copy link
Member Author

dnhatn commented Feb 3, 2022

Thanks Yannick!

@dnhatn dnhatn added v8.1.1 v8.0.1 v7.17.1 auto-backport-and-merge Automatically create backport pull requests and merge when ready labels Feb 3, 2022
@dnhatn dnhatn merged commit 3d4e784 into elastic:master Feb 3, 2022
@dnhatn dnhatn deleted the pit-no-index-matched branch February 3, 2022 14:55
dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Feb 3, 2022
@dnhatn
Returns valid PIT when no index matched (elastic#83424)
683b1c8 
We should return a valid PIT instead of tripping an assertion when the 
index wildcard matches no index.
@dnhatn dnhatn mentioned this pull request Feb 3, 2022
Merged
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 7.17 Commit could not be cherrypicked due to conflicts
❌ 8.0 Commit could not be cherrypicked due to conflicts
✅ 8.1

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 83424

elasticsearchmachine pushed a commit that referenced this pull request Feb 3, 2022
@dnhatn
Returns valid PIT when no index matched (#83424) (#83455)
3823575 
We should return a valid PIT instead of tripping an assertion when the 
index wildcard matches no index.
This was referenced Feb 8, 2022
Merged
Merged
dnhatn added a commit that referenced this pull request Feb 8, 2022
@dnhatn
Returns valid PIT when no index matched (#83621)
caebd84 
Backport of #83424
dnhatn added a commit that referenced this pull request Feb 8, 2022
@dnhatn
Returns valid PIT when no index matched (#83618)
996c697 
Backport of #83424
@dnhatn dnhatn mentioned this pull request Apr 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywelsch ywelsch ywelsch approved these changes

Assignees
No one assigned
Labels
auto-backport-and-merge Automatically create backport pull requests and merge when ready >bug :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team v7.17.1 v8.0.1 v8.1.1 v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dnhatn @elasticmachine @elasticsearchmachine @ywelsch @mark-vieira