Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't wait joinThread when stopping #8359

Closed
wants to merge 2 commits into from
Closed

Don't wait joinThread when stopping #8359

wants to merge 2 commits into from

Commits on Nov 6, 2014

  1. Discovery: a more lenient wait joinThread when stopping 

    When a node stops, we cancel any ongoing join process. With elastic#8327, we improved this logic and wait for it to complete before shutting down the node. In our tests we typically shutdown an entire cluster at once, which makes it very likely for nodes to be joining while shutting down. This introduces a race condition where the joinThread.interrupt can happen before the thread starts waiting on pings which causes shutdown logic to be slow. This commits improves by repeatedly trying to stop the thread in smaller waits.

Another side effect of the change is that we are now more likely to ping ourselves while shutting down, we results in an ugly warn level log. We now log all remote exception during pings at a debug level.
    @bleskes
    bleskes committed Nov 6, 2014
    Copy the full SHA
    0c8d31f View commit details
    Browse the repository at this point in the history

  2. don't wait on joinThread at all. it's a thread pool thread.

    @bleskes
    bleskes committed Nov 6, 2014
    Copy the full SHA
    00955da View commit details
    Browse the repository at this point in the history