-
Notifications
You must be signed in to change notification settings - Fork 24.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove LegacyCTRAListener from open-indices batching #83807
Merged
joegallo
merged 4 commits into
elastic:master
from
joegallo:remove-LegacyClusterTaskResultActionListener
Feb 10, 2022
Merged
Remove LegacyCTRAListener from open-indices batching #83807
joegallo
merged 4 commits into
elastic:master
from
joegallo:remove-LegacyClusterTaskResultActionListener
Feb 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joegallo
added
>non-issue
:Distributed/Cluster Coordination
Cluster formation and cluster state publication, including cluster membership and fault detection.
v8.2.0
labels
Feb 10, 2022
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
reviewed
Feb 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I suggested a simplification
server/src/main/java/org/elasticsearch/cluster/metadata/MetadataIndexStateService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/metadata/MetadataIndexStateService.java
Outdated
Show resolved
Hide resolved
16 tasks
DaveCTurner
approved these changes
Feb 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rjernst
pushed a commit
to rjernst/elasticsearch
that referenced
this pull request
Feb 12, 2022
tlrx
pushed a commit
to tlrx/elasticsearch
that referenced
this pull request
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Distributed/Cluster Coordination
Cluster formation and cluster state publication, including cluster membership and fault detection.
>non-issue
Team:Distributed
Meta label for distributed team
v8.2.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #83760, related to #83784
Also, fixed the changelog from that PR while I was here (I changed the title on the previous PR, but the changelog caught the old description).