Allow removing unreferenced composable data stream templates #84376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously there was a bug where when we retrieved the list of data streams using a template, we only checked index patterns, rather than actually comparing priorities and only treating the highest priority template as "referenced". This commit fixes this problem by only treating the matching composable template as referenced, allowing unreferenced templates to be safely deleted. Resolves elastic#84188 Resolves elastic#84171
dakrone
added
>bug
:Data Management/Indices APIs
elasticmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
Hi @dakrone, I've created a changelog YAML for you. |
andreidan
approved these changes
Feb 28, 2022
| client().execute(PutComposableIndexTemplateAction.INSTANCE, request).actionGet(); | ||
|
|
||
| DeleteComposableIndexTemplateAction.Request deleteRequest = new DeleteComposableIndexTemplateAction.Request("id"); | ||
| client().execute(DeleteComposableIndexTemplateAction.INSTANCE, deleteRequest).get(); |
There was a problem hiding this comment.
Would it be worth adding an assertion the template is actually deleted/missing from the system? (to fend against bugs that'd swallow the exception or such)
There was a problem hiding this comment.
Good idea, I've added this.
dakrone
force-pushed
the
allow-deleting-unreferenced-templates
branch
from
0738c28
to
e9e9d0b
Compare
dakrone
added
auto-backport-and-merge
|
@elasticmachine update branch |
|
@elasticmachine update branch |
This was referenced Feb 28, 2022
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Feb 28, 2022
…#84376) Previously there was a bug where when we retrieved the list of data streams using a template, we only checked index patterns, rather than actually comparing priorities and only treating the highest priority template as "referenced". This commit fixes this problem by only treating the matching composable template as referenced, allowing unreferenced templates to be safely deleted. Resolves elastic#84188 Resolves elastic#84171
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Feb 28, 2022
…#84376) Previously there was a bug where when we retrieved the list of data streams using a template, we only checked index patterns, rather than actually comparing priorities and only treating the highest priority template as "referenced". This commit fixes this problem by only treating the matching composable template as referenced, allowing unreferenced templates to be safely deleted. Resolves elastic#84188 Resolves elastic#84171
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Feb 28, 2022
…#84376) Previously there was a bug where when we retrieved the list of data streams using a template, we only checked index patterns, rather than actually comparing priorities and only treating the highest priority template as "referenced". This commit fixes this problem by only treating the matching composable template as referenced, allowing unreferenced templates to be safely deleted. Resolves elastic#84188 Resolves elastic#84171
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 28, 2022
…#84449) Previously there was a bug where when we retrieved the list of data streams using a template, we only checked index patterns, rather than actually comparing priorities and only treating the highest priority template as "referenced". This commit fixes this problem by only treating the matching composable template as referenced, allowing unreferenced templates to be safely deleted. Resolves #84188 Resolves #84171
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 28, 2022
…#84450) Previously there was a bug where when we retrieved the list of data streams using a template, we only checked index patterns, rather than actually comparing priorities and only treating the highest priority template as "referenced". This commit fixes this problem by only treating the matching composable template as referenced, allowing unreferenced templates to be safely deleted. Resolves #84188 Resolves #84171
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 28, 2022
…84376) (#84452) * Allow removing unreferenced composable data stream templates (#84376) Previously there was a bug where when we retrieved the list of data streams using a template, we only checked index patterns, rather than actually comparing priorities and only treating the highest priority template as "referenced". This commit fixes this problem by only treating the matching composable template as referenced, allowing unreferenced templates to be safely deleted. Resolves #84188 Resolves #84171 * Fix compilation for old JDK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously there was a bug where when we retrieved the list of data streams using a template, we
only checked index patterns, rather than actually comparing priorities and only treating the highest
priority template as "referenced". This commit fixes this problem by only treating the matching
composable template as referenced, allowing unreferenced templates to be safely deleted.
Resolves #84188
Resolves #84171