Validate index format agreement for system index descriptors #85173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamrandolph
added
>bug
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
Hi @williamrandolph, I've created a changelog YAML for you. |
pugnascotia
reviewed
Mar 22, 2022
| // post a watch | ||
| Request putWatchRequest = new Request("PUT", "_watcher/watch/log_error_watch"); | ||
| putWatchRequest.setJsonEntity( | ||
| "{\n" |
There was a problem hiding this comment.
We can use multiline strings here now
pugnascotia
approved these changes
Mar 22, 2022
williamrandolph
added
the
auto-backport-and-merge
💔 Backport failed
You can use sqren/backport to manually backport by running |
williamrandolph
added a commit
to williamrandolph/elasticsearch
that referenced
this pull request
Mar 23, 2022
…#85173) * Validate index format for system indices * Add bwc test for watcher meta version issue * Update docs/changelog/85173.yaml
williamrandolph
added a commit
to williamrandolph/elasticsearch
that referenced
this pull request
Mar 23, 2022
…#85173) * Validate index format for system indices * Add bwc test for watcher meta version issue * Update docs/changelog/85173.yaml
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
SystemIndexManagerclass checks the index format for an internally managed system index, it compares a value in the system index descriptor with a value in the index's stored settings. If the two values differ,SystemIndexManagerconcludes that some external migration needs to be triggered before it can update the system index's mappings and metadata. However, if our code had different numbers in the descriptor and in the settings, that descriptor's system indices will always be in a state where they can't be updated, since users can't override the defined settings.This PR adds validation to the system index descriptor so that we will catch any system index descriptors with this problem, and we add bwc tests for the watcher case.
Relates #84880