Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return empty version instead of blowing up if we cannot find it #85244

Merged
merged 2 commits into from
Mar 23, 2022
Merged

Return empty version instead of blowing up if we cannot find it #85244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c59db2d
Return empty version instead of blowing up if we cannot find it
masseyke Mar 22, 2022
9012dee
Update docs/changelog/85244.yaml
masseyke Mar 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/changelog/85244.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 85244
summary: Return empty version instead of blowing up if we cannot find it
area: Infra/Core
type: bug
issues: []
7 changes: 2 additions & 5 deletions server/src/main/java/org/elasticsearch/indices/SystemIndexManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,12 +310,9 @@ private Version readMappingVersion(SystemIndexDescriptor descriptor, MappingMeta
return Version.V_EMPTY;
}
return Version.fromString(versionString);
} catch (ElasticsearchParseException e) {
} catch (ElasticsearchParseException | IllegalArgumentException e) {
logger.error(new ParameterizedMessage("Cannot parse the mapping for index [{}]", indexName), e);
throw new ElasticsearchException("Cannot parse the mapping for index [{}]", e, indexName);
} catch (IllegalArgumentException e) {
logger.error(new ParameterizedMessage("Cannot parse the mapping for index [{}]", indexName), e);
throw e;
return Version.V_EMPTY;
}
}

Expand Down