[ML] Do not fetch source when finding index of last state docs #85334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two places where the ML code needs to find out which index in the rolling sequence of state indices the previous state document is in. Previously the search to do this was needlessly retrieving _source, which wastes memory. The change tells the two searches not to fetch _source, only the metadata.
droberts195
added
>bug
:ml
|
Pinging @elastic/ml-core (Team:ML) |
|
Hi @droberts195, I've created a changelog YAML for you. |
|
Jenkins test this |
|
@elasticmachine update branch |
|
Jenkins run elasticsearch-ci/part-1 |
This was referenced Mar 24, 2022
droberts195
added a commit
to droberts195/elasticsearch
that referenced
this pull request
Mar 24, 2022
…ic#85334) There are two places where the ML code needs to find out which index in the rolling sequence of state indices the previous state document is in. Previously the search to do this was needlessly retrieving _source, which wastes memory. The change tells the two searches not to fetch _source, only the metadata.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 24, 2022
… (#85344) There are two places where the ML code needs to find out which index in the rolling sequence of state indices the previous state document is in. Previously the search to do this was needlessly retrieving _source, which wastes memory. The change tells the two searches not to fetch _source, only the metadata.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 24, 2022
… (#85343) There are two places where the ML code needs to find out which index in the rolling sequence of state indices the previous state document is in. Previously the search to do this was needlessly retrieving _source, which wastes memory. The change tells the two searches not to fetch _source, only the metadata. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two places where the ML code needs to find out which
index in the rolling sequence of state indices the previous
state document is in.
Previously the search to do this was needlessly retrieving
_source, which wastes memory.
The change tells the two searches not to fetch _source, only
the metadata.