Fix skip caching factor with indices.queries.cache.all_segments #85510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
>bug
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
|
Hi @dnhatn, I've created a changelog YAML for you. |
jtibshirani
approved these changes
Mar 30, 2022
| @@ -345,6 +353,79 @@ public void testStatsOnEviction() throws IOException { | |||
| cache.close(); // this triggers some assertions | |||
| } | |||
|
|
|||
| public void testSkipCachingFactorAtLeast10() throws Exception { | |||
There was a problem hiding this comment.
Small comment -- to me this test doesn't add much except guard against someone accidentally changing the skip factor. I think it'd accomplish the same to add a code comment like "the skipFactor must be 10 here to match the default in Lucene's LRUQueryCache".
jpountz
approved these changes
Mar 31, 2022
|
@jtibshirani @jpountz Thanks for review. |
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Apr 1, 2022
…tic#85510) The indices.queries.cache.all_segments setting should not be used in production environments. And we should also use the default skipCachingFactor (i.e, 10) for when that setting is enabled.
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Apr 1, 2022
…tic#85510) The indices.queries.cache.all_segments setting should not be used in production environments. And we should also use the default skipCachingFactor (i.e, 10) for when that setting is enabled.
This was referenced Apr 1, 2022
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Apr 1, 2022
…tic#85510) The indices.queries.cache.all_segments setting should not be used in production environments. And we should also use the default skipCachingFactor (i.e, 10) for when that setting is enabled.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 1, 2022
…) (#85646) The indices.queries.cache.all_segments setting should not be used in production environments. And we should also use the default skipCachingFactor (i.e, 10) for when that setting is enabled.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 1, 2022
…) (#85647) The indices.queries.cache.all_segments setting should not be used in production environments. And we should also use the default skipCachingFactor (i.e, 10) for when that setting is enabled.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 1, 2022
…) (#85648) The indices.queries.cache.all_segments setting should not be used in production environments. And we should also use the default skipCachingFactor (i.e, 10) for when that setting is enabled. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spin off #85423
The
indices.queries.cache.all_segmentssetting should not be used in production environments. And we should also use the defaultskipCachingFactor(i.e, 10) for LRUQueryCache when that setting is enabled.