Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump commons-compress to 1.21 #85581

Merged

Conversation

dakrone
Copy link
Member

@dakrone dakrone commented Mar 31, 2022

This updates the dependency version for the Apache commons compress project to 1.21

This updates the dependency version for the Apache commons compress project to 1.21
@dakrone dakrone added >bug :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP v8.0.2 v7.17.3 v8.1.3 v8.2.1 labels Mar 31, 2022
@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Mar 31, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine
Copy link
Collaborator

Hi @dakrone, I've created a changelog YAML for you.

@@ -55,7 +55,7 @@ dependencies {
// MS Office
api "org.apache.poi:poi-scratchpad:${versions.poi}"
// Apple iWork
api 'org.apache.commons:commons-compress:1.19'
api 'org.apache.commons:commons-compress:1.21'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can see this is the only use of this dependency in actual production code. Everything else is either build logic or test code. Does that seem right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep that's correct

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dakrone
Copy link
Member Author

dakrone commented Apr 1, 2022

@elasticmachine update branch

@dakrone
Copy link
Member Author

dakrone commented Apr 4, 2022

@elasticmachine update branch

@dakrone dakrone added auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) auto-backport-and-merge Automatically create backport pull requests and merge when ready labels Apr 4, 2022
@elasticsearchmachine elasticsearchmachine merged commit 3a3ee6e into elastic:master Apr 4, 2022
@dakrone dakrone deleted the update-commons-compress branch April 4, 2022 05:04
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.0 Commit could not be cherrypicked due to conflicts
7.17 Commit could not be cherrypicked due to conflicts
8.1 Commit could not be cherrypicked due to conflicts
8.2 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 85581

dakrone added a commit to dakrone/elasticsearch that referenced this pull request Apr 4, 2022
This updates the dependency version for the Apache commons compress
project to 1.21
# Conflicts:
#	build-tools/build.gradle
dakrone added a commit to dakrone/elasticsearch that referenced this pull request Apr 4, 2022
This updates the dependency version for the Apache commons compress
project to 1.21
# Conflicts:
#	build-tools/build.gradle
#	distribution/tools/geoip-cli/build.gradle
#	test/x-content/build.gradle
dakrone added a commit to dakrone/elasticsearch that referenced this pull request Apr 4, 2022
This updates the dependency version for the Apache commons compress
project to 1.21
# Conflicts:
#	build-tools/build.gradle
#	distribution/tools/geoip-cli/build.gradle
#	test/x-content/build.gradle
dakrone added a commit to dakrone/elasticsearch that referenced this pull request Apr 4, 2022
This updates the dependency version for the Apache commons compress
project to 1.21
# Conflicts:
#	build-tools/build.gradle
#	distribution/tools/geoip-cli/build.gradle
#	test/x-content/build.gradle
elasticsearchmachine pushed a commit that referenced this pull request Apr 4, 2022
This updates the dependency version for the Apache commons compress
project to 1.21
# Conflicts:
#	build-tools/build.gradle
elasticsearchmachine pushed a commit that referenced this pull request Apr 4, 2022
* Bump commons-compress to 1.21 (#85581)

This updates the dependency version for the Apache commons compress
project to 1.21
# Conflicts:
#	build-tools/build.gradle
#	distribution/tools/geoip-cli/build.gradle
#	test/x-content/build.gradle

* Fix backport
@pugnascotia pugnascotia added >upgrade and removed >bug labels Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport-and-merge Automatically create backport pull requests and merge when ready auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP Team:Data Management Meta label for data/management team >upgrade v7.17.3 v8.2.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants