https://github.com/glennvill/elasticsearch.git #85776
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
v8.3.0
external-contributor
gmarouli
added
the
:Analytics/Geo
elasticmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
craigtaverner
requested changes
Jun 1, 2022
| @@ -119,8 +119,6 @@ public GeoBoundingBoxQueryBuilder setCorners(double top, double left, double bot | |||
| // all corners are valid after above checks - make sure they are in the right relation | |||
| if (top < bottom) { | |||
| throw new IllegalArgumentException("top is below bottom corner: " + top + " vs. " + bottom); | |||
| } else if (top == bottom) { | |||
| throw new IllegalArgumentException("top cannot be the same as bottom: " + top + " == " + bottom); | |||
| } else if (left == right) { | |||
There was a problem hiding this comment.
You missed the left == right check which should also be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed query builder so that top can be the same as bottom
As the same bounding box on a geo_shape query works. Lucene supports it so this fix is a must