New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for geo_point in top_metrics aggregation #87080
base: main
Are you sure you want to change the base?
Conversation
# Conflicts: # server/src/main/java/org/elasticsearch/index/fielddata/FieldData.java
Pinging @elastic/es-analytics-geo (Team:Analytics) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's how to do it, yeah.
I do think our lack of support for fetching all of the values of a field is a problem - there's an issue for it that came up many months after we wrote the feature. And I imagine it's a bigger problem with geo because arrays of points is not uncommon.
I don't think so as when I see points as metrics I imagine more a device reporting its position so in general point metrics should be single valued. At the moment the biggest issue (and it is not specific to this aggregation) is the format of geo_point doc values. They come as a string"lat, lon" which is totally different to the formats supported for the fields API. |
Ah! When I implements |
This PR adds the possibility of adding fields of type geo_point as a metric in the top_metrics aggregation. /It currently just output the first point in case of an array of points with the format "lat, lon".