Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script: Load Whitelists as Resource #87539

Merged
merged 5 commits into from Jun 9, 2022

Conversation

stu-elastic
Copy link
Contributor

Changes PainlessPlugin.class.getResourceAsStream to
PainlessPlugin.class.getResource to avoid leaking unclosed
input streams

Changes PainlessPlugin.class.getResourceAsStream to
PainlessPlugin.class.getResource to avoid leaking unclosed
input streams
@stu-elastic stu-elastic added >bug :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache auto-backport-and-merge Automatically create backport pull requests and merge when ready v7.17.5 v8.4.0 v8.3.1 labels Jun 8, 2022
@elasticsearchmachine
Copy link
Collaborator

Hi @stu-elastic, I've created a changelog YAML for you.

@stu-elastic stu-elastic marked this pull request as ready for review June 9, 2022 14:05
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Jun 9, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stu-elastic stu-elastic merged commit b05ed2f into elastic:master Jun 9, 2022
stu-elastic added a commit to stu-elastic/elasticsearch that referenced this pull request Jun 9, 2022
Changes PainlessPlugin.class.getResourceAsStream to
PainlessPlugin.class.getResource to avoid leaking unclosed
input streams
stu-elastic added a commit to stu-elastic/elasticsearch that referenced this pull request Jun 9, 2022
Changes PainlessPlugin.class.getResourceAsStream to
PainlessPlugin.class.getResource to avoid leaking unclosed
input streams
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
7.17
8.3

elasticsearchmachine pushed a commit that referenced this pull request Jun 9, 2022
Changes PainlessPlugin.class.getResourceAsStream to
PainlessPlugin.class.getResource to avoid leaking unclosed
input streams
elasticsearchmachine pushed a commit that referenced this pull request Jun 9, 2022
Changes PainlessPlugin.class.getResourceAsStream to
PainlessPlugin.class.getResource to avoid leaking unclosed
input streams
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport-and-merge Automatically create backport pull requests and merge when ready >bug :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache Team:Core/Infra Meta label for core/infra team v7.17.5 v8.3.1 v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants