New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more fine grained memory stats from Lucene segment reader to index stats #8832

Merged
merged 1 commit into from Dec 8, 2014

Conversation

Projects
None yet
4 participants
@rjernst
Member

rjernst commented Dec 8, 2014

This is a start to exposing memory stats improvements from Lucene 5.0.
This adds the following categories of Lucene index pieces to index stats:

  • Terms
  • Stored fields
  • Term Vectors
  • Norms
  • Doc values
@rmuir

This comment has been minimized.

Show comment
Hide comment
@rmuir

rmuir Dec 8, 2014

Contributor

looks good, thank you!

Contributor

rmuir commented Dec 8, 2014

looks good, thank you!

@kimchy

This comment has been minimized.

Show comment
Hide comment
@kimchy

kimchy Dec 8, 2014

Member

LGTM, wonderful!

Member

kimchy commented Dec 8, 2014

LGTM, wonderful!

@@ -1225,7 +1229,13 @@ public SegmentsStats segmentsStats() {
try (final Searcher searcher = acquireSearcher("segments_stats")) {

This comment has been minimized.

@s1monw

s1monw Dec 8, 2014

Contributor

can we have a unittest for this in InternalEngineTest maybe?

@s1monw

s1monw Dec 8, 2014

Contributor

can we have a unittest for this in InternalEngineTest maybe?

This comment has been minimized.

@rjernst

rjernst Dec 8, 2014

Member

@s1monw yes I will add in a follow up commit

@rjernst

rjernst Dec 8, 2014

Member

@s1monw yes I will add in a follow up commit

This comment has been minimized.

@rjernst

rjernst Dec 8, 2014

Member

@s1monw Added a test in 0c8f5ac

@rjernst

rjernst Dec 8, 2014

Member

@s1monw Added a test in 0c8f5ac

Stats: Add more fine grained memory stats from Lucene segment reader.
This is a start to exposing memory stats improvements from Lucene 5.0.
This adds the following categories of Lucene index pieces to index stats:
* Terms
* Stored fields
* Term Vectors
* Norms
* Doc values

@rjernst rjernst merged commit fde32cc into elastic:master Dec 8, 2014

@rjernst rjernst deleted the rjernst:pr/mem-stats branch Jan 21, 2015

@clintongormley clintongormley changed the title from Stats: Add more fine grained memory stats from Lucene segment reader. to Add more fine grained memory stats from Lucene segment reader to index stats Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment