Dates: Fixed parsing issue with exact dates when using lte. #8834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Date parsing uses a flag to indicate whether the rounding should be inclusive or exclusive. This change fixes the parsing to not use this logic in the case of exact dates that do not have rounding syntax. closes elastic#8490
| public void testRoundingDoesNotAffectExactDate() { | ||
| assertDateMathEquals("2014", "2014-01-01T00:00:00.000", 0, true, null); | ||
| assertDateMathEquals("2014", "2014-01-01T00:00:00.000", 0, false, null); | ||
| } |
There was a problem hiding this comment.
ok, but I get three test failures when I run the full suite:
Tests with failures:
- org.elasticsearch.search.simple.SimpleSearchTests.simpleDateRangeWithUpperInclusiveEnabledTests
- org.elasticsearch.index.mapper.date.SimpleDateMappingTests.testDayWithoutYearFormat
- org.elasticsearch.index.mapper.date.SimpleDateMappingTests.testHourFormat
also, should we have the example from the original issue as test?
There was a problem hiding this comment.
Yeah I just fixed those test failures. I will change this test to use the date from the original issue.
|
Thanks @brwe I pushed changes addressing your comments. |
|
I'm closing this since it can be accomplished in 1.x by disabling |
clintongormley
added
:Search/Mapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date parsing uses a flag to indicate whether the rounding should be
inclusive or exclusive. This change fixes the parsing to not use this
logic in the case of exact dates that do not have rounding syntax.
closes #8490