Extract field name from MappedFieldType #88475
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywelsch
added
:Search Foundations/Mapping
|
Pinging @elastic/es-search (Team:Search) |
ywelsch
commented
Jul 12, 2022
| if (ft instanceof final RankFeatureFieldType fft) { | ||
| return scoreFunction.toQuery(RankFeatureMetaFieldMapper.NAME, field, fft.positiveScoreImpact()); | ||
| } else if (ft == null) { | ||
| if (mappedField == null) { |
There was a problem hiding this comment.
I reordered the if/else clauses here to move the null check to the top (as we can't otherwise call mappedField.type() without a NPE)
| boolean isIndexed, | ||
| boolean isStored, | ||
| boolean hasDocValues, | ||
| TextSearchInfo textSearchInfo, | ||
| Map<String, String> meta | ||
| ) { | ||
| this.name = Mapper.internFieldName(name); |
There was a problem hiding this comment.
This has moved to the MappedField class now.
| if (context.allowExpensiveQueries() == false) { | ||
| throw new ElasticsearchException( | ||
| "runtime-computed exists query cannot be executed while [" + ALLOW_EXPENSIVE_QUERIES.getKey() + "] is set to [false]." | ||
| ); | ||
| } | ||
| return existQueryFieldType.existsQuery(context); | ||
| // norms are not available, neither are doc-values, so fall back to _source to run exists query | ||
| final MappedField existQueryField = KeywordScriptFieldType.sourceOnly(name).asMappedFields().findFirst().get(); |
There was a problem hiding this comment.
this was moved from the constructor of LegacyTextFieldType now to the invocation site here, as we need the name to construct the existQueryField
romseygeek
approved these changes
Jul 13, 2022
| import java.util.function.Function; | ||
| import java.util.function.Supplier; | ||
|
|
||
| public class MappedField { |
There was a problem hiding this comment.
Can we have some javadoc here?
|
We did not go ahead with this change, see #86440 (comment) . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separates the field name from MappedFieldType, making MappedFieldType just a container for type-related information.
The combination of field name and typing information is now available via a new MappedField class.
As follow-up, we would like to implement equals/hashCode on this new name-stripped MappedFieldType, so that we can deduplicate MappedFieldType instances. This should dramatically lower the memory usage of large mappings on data nodes.
Relates #86440