Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep test folders of failed build tools integration tests #89296

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Keep test folders of failed build tools integration tests #89296

merged 1 commit into from
Aug 12, 2022

Conversation

breskeby
Copy link
Contributor

@breskeby breskeby commented Aug 12, 2022 •
edited

This simplifies our debugging logic we have in place to keep the test build environment for failed tests, making debugging easier without dealing with magic flags

@breskeby breskeby self-assigned this Aug 12, 2022
@breskeby breskeby added :Delivery/Build Build or test infrastructure >enhancement auto-backport-and-merge Automatically create backport pull requests and merge when ready auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) Team:Delivery Meta label for Delivery team v7.17.6 labels Aug 12, 2022
@breskeby breskeby marked this pull request as ready for review August 12, 2022 06:52
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@breskeby breskeby mentioned this pull request Aug 12, 2022
Closed
@elasticsearchmachine elasticsearchmachine merged commit da3e4e8 into elastic:main Aug 12, 2022
@breskeby breskeby deleted the keep-failed-temp-folders branch August 12, 2022 07:15
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 7.17 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 89296

breskeby added a commit to breskeby/elasticsearch that referenced this pull request Aug 12, 2022
@breskeby
Keep test folders of failed build tools integration tests (elastic#89296
a7b0df6 
)

This simplifies our debugging logic we have in place to keep the test
build environment for failed tests, making debugging easier without
dealing with magic flags
# Conflicts:
#	build-tools/src/testFixtures/groovy/org/elasticsearch/gradle/fixtures/AbstractGradleFuncTest.groovy
@breskeby breskeby mentioned this pull request Aug 12, 2022
Merged
jan0sch pushed a commit to wegtam/elasticsearch that referenced this pull request Aug 16, 2022
@breskeby
Keep test folders of failed build tools integration tests (elastic#89296
ada1852 
) (elastic#89308)

Backports the following commits to 7.17:
 - Keep test folders of failed build tools integration tests (elastic#89296)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@breskeby breskeby

Labels
auto-backport-and-merge Automatically create backport pull requests and merge when ready auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Delivery/Build Build or test infrastructure >enhancement Team:Delivery Meta label for Delivery team v7.17.6 v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@breskeby @elasticsearchmachine