Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sync allocate implementation #89683

Draft
wants to merge 1 commit into
base: feature/desired-balance-allocator
Choose a base branch
from
Draft

Remove sync allocate implementation #89683

wants to merge 1 commit into from

Conversation

idegtiarenko
Copy link
Contributor

No description provided.

@idegtiarenko idegtiarenko added :Distributed/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) Team:Distributed Meta label for distributed team labels Aug 29, 2022
idegtiarenko
idegtiarenko commented Aug 29, 2022
View reviewed changes
...er/src/main/java/org/elasticsearch/cluster/routing/allocation/allocator/ShardsAllocator.java
default void allocate(RoutingAllocation allocation, ActionListener<Void> listener) {
allocate(allocation);
listener.onResponse(null);
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only thing removed. Diff is caused by moving default execute method to the bottom.

@DaveCTurner
Copy link
Contributor

I think this is still worth doing, although it'll need fixing up and retargeting at main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaveCTurner DaveCTurner Awaiting requested review from DaveCTurner

Assignees
No one assigned
Labels
:Distributed/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) Team:Distributed Meta label for distributed team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@idegtiarenko @DaveCTurner