New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix debug mode in MaxRetryAllocationDecider #89973
Merged
elasticsearchmachine
merged 3 commits into
elastic:main
from
DaveCTurner:2022-09-09-MaxRetryAllocationDecider-debug-mode
Sep 9, 2022
Merged
Fix debug mode in MaxRetryAllocationDecider #89973
elasticsearchmachine
merged 3 commits into
elastic:main
from
DaveCTurner:2022-09-09-MaxRetryAllocationDecider-debug-mode
Sep 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In elastic#62275 we refactored this code a bit and inadvertently reversed the sense of this conditional when running in debug mode. This commit fixes the mistake.
DaveCTurner
added
>bug
:Distributed/Allocation
All issues relating to the decision making around placing a shard (both master logic & on the nodes)
v8.5.0
v7.17.7
v8.4.2
labels
Sep 9, 2022
Pinging @elastic/es-distributed (Team:Distributed) |
Hi @DaveCTurner, I've created a changelog YAML for you. |
idegtiarenko
approved these changes
Sep 9, 2022
original-brownbear
approved these changes
Sep 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wops sorry about that LGTM
DaveCTurner
added
auto-merge
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
auto-backport-and-merge
Automatically create backport pull requests and merge when ready
labels
Sep 9, 2022
DaveCTurner
deleted the
2022-09-09-MaxRetryAllocationDecider-debug-mode
branch
September 9, 2022 16:39
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Sep 9, 2022
In elastic#62275 we refactored this code a bit and inadvertently reversed the sense of this conditional when running in debug mode. This commit fixes the mistake.
💔 Backport failed
You can use sqren/backport to manually backport by running |
DaveCTurner
added a commit
that referenced
this pull request
Sep 9, 2022
In #62275 we refactored this code a bit and inadvertently reversed the sense of this conditional when running in debug mode. This commit fixes the mistake.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport-and-merge
Automatically create backport pull requests and merge when ready
auto-merge
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
>bug
:Distributed/Allocation
All issues relating to the decision making around placing a shard (both master logic & on the nodes)
Team:Distributed
Meta label for distributed team
v7.17.7
v8.4.2
v8.5.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #62275 we refactored this code a bit and inadvertently reversed the sense of this conditional when running in debug mode. This commit fixes the mistake.