Function score and optional weight : avg score is wrong #9004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -300,11 +306,15 @@ public float innerScore() throws IOException { | |||
| } | |||
| } else { // Avg / Total | |||
| double totalFactor = 0.0f; | |||
| int count = 0; | |||
| float count = 0; | |||
There was a problem hiding this comment.
This should probably be renamed to weightSum as well.
|
@ghiron I left a minor comment. Can you also fix the spacing, so that everything is even? e.g. |
fix spaces formatting rename weightsSum as weightSum
|
@rjernst Done |
rjernst
added
v2.0.0-beta1
v1.5.0
v1.4.3
:Core/Infra/Scripting
|
Thanks @ghiron! |
clintongormley
changed the title
clintongormley
changed the title
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8992