-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix another potential race in the file settings watcher #90302
Conversation
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Hi @thecoop, I've created a changelog YAML for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks Simon!
Hit a similar problem in https://gradle-enterprise.elastic.co/s/qqumxaoxabvuc/tests/:test:framework:integTest/org.elasticsearch.test.test.TestScopeClusterIT/testReproducible?top-execution=1. That was in |
Hi @dimitris-athanasiou, yes it should be in 8.5 too, we should backport, all the way to 8.4. |
Fix another potential race in the file settings watcher for issue elastic#89500
Fix another potential race in the file settings watcher for issue elastic#89500
* Update docs for v8.4.3 release * Update release highlights for 8.4.3 version. * Update docs/reference/release-notes/8.4.3.asciidoc Co-authored-by: Adam Locke <adam.locke@elastic.co> * Update docs/reference/release-notes/8.4.3.asciidoc Co-authored-by: Adam Locke <adam.locke@elastic.co> * Update docs/reference/release-notes/highlights.asciidoc Co-authored-by: Adam Locke <adam.locke@elastic.co> * Make link external type * Update release notes to include #90319 PR after creating BC2. * Remove release note for #90302 * Minor grammar fix Co-authored-by: Adam Locke <adam.locke@elastic.co>
* Update docs for v8.4.3 release * Update release highlights for 8.4.3 version. * Update docs/reference/release-notes/8.4.3.asciidoc Co-authored-by: Adam Locke <adam.locke@elastic.co> * Update docs/reference/release-notes/8.4.3.asciidoc Co-authored-by: Adam Locke <adam.locke@elastic.co> * Update docs/reference/release-notes/highlights.asciidoc Co-authored-by: Adam Locke <adam.locke@elastic.co> * Make link external type * Update release notes to include elastic#90319 PR after creating BC2. * Remove release note for elastic#90302 * Minor grammar fix Co-authored-by: Adam Locke <adam.locke@elastic.co> (cherry picked from commit 25a196f) # Conflicts: # docs/reference/release-notes.asciidoc # docs/reference/release-notes/highlights.asciidoc
* Update docs for v8.4.3 release * Update release highlights for 8.4.3 version. * Update docs/reference/release-notes/8.4.3.asciidoc Co-authored-by: Adam Locke <adam.locke@elastic.co> * Update docs/reference/release-notes/8.4.3.asciidoc Co-authored-by: Adam Locke <adam.locke@elastic.co> * Update docs/reference/release-notes/highlights.asciidoc Co-authored-by: Adam Locke <adam.locke@elastic.co> * Make link external type * Update release notes to include elastic#90319 PR after creating BC2. * Remove release note for elastic#90302 * Minor grammar fix Co-authored-by: Adam Locke <adam.locke@elastic.co> (cherry picked from commit 25a196f) # Conflicts: # docs/reference/release-notes.asciidoc # docs/reference/release-notes/highlights.asciidoc
* Update docs for v8.4.3 release * Update release highlights for 8.4.3 version. * Update docs/reference/release-notes/8.4.3.asciidoc Co-authored-by: Adam Locke <adam.locke@elastic.co> * Update docs/reference/release-notes/8.4.3.asciidoc Co-authored-by: Adam Locke <adam.locke@elastic.co> * Update docs/reference/release-notes/highlights.asciidoc Co-authored-by: Adam Locke <adam.locke@elastic.co> * Make link external type * Update release notes to include #90319 PR after creating BC2. * Remove release note for #90302 * Minor grammar fix Co-authored-by: Adam Locke <adam.locke@elastic.co> (cherry picked from commit 25a196f) # Conflicts: # docs/reference/release-notes.asciidoc # docs/reference/release-notes/highlights.asciidoc Co-authored-by: Slobodan Adamović <slobodanadamovic@users.noreply.github.com>
* Update docs for v8.4.3 release * Update release highlights for 8.4.3 version. * Update docs/reference/release-notes/8.4.3.asciidoc Co-authored-by: Adam Locke <adam.locke@elastic.co> * Update docs/reference/release-notes/8.4.3.asciidoc Co-authored-by: Adam Locke <adam.locke@elastic.co> * Update docs/reference/release-notes/highlights.asciidoc Co-authored-by: Adam Locke <adam.locke@elastic.co> * Make link external type * Update release notes to include #90319 PR after creating BC2. * Remove release note for #90302 * Minor grammar fix Co-authored-by: Adam Locke <adam.locke@elastic.co> (cherry picked from commit 25a196f) # Conflicts: # docs/reference/release-notes.asciidoc # docs/reference/release-notes/highlights.asciidoc Co-authored-by: Slobodan Adamović <slobodanadamovic@users.noreply.github.com>
* Update docs for v8.4.3 release * Update release highlights for 8.4.3 version. * Update docs/reference/release-notes/8.4.3.asciidoc Co-authored-by: Adam Locke <adam.locke@elastic.co> * Update docs/reference/release-notes/8.4.3.asciidoc Co-authored-by: Adam Locke <adam.locke@elastic.co> * Update docs/reference/release-notes/highlights.asciidoc Co-authored-by: Adam Locke <adam.locke@elastic.co> * Make link external type * Update release notes to include elastic#90319 PR after creating BC2. * Remove release note for elastic#90302 * Minor grammar fix Co-authored-by: Adam Locke <adam.locke@elastic.co> (cherry picked from commit 25a196f) # Conflicts: # docs/reference/release-notes.asciidoc # docs/reference/release-notes/highlights.asciidoc Co-authored-by: Slobodan Adamović <slobodanadamovic@users.noreply.github.com>
Fix race in the shutdown code of FileSettingsWatcher
Potential fix for #89500