Handling timeout exceptions on watcher startup #90421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @masseyke, I've created a changelog YAML for you. |
|
@elasticmachine update branch |
|
Pinging @elastic/es-data-management (Team:Data Management) |
elasticsearchmachine
added
the
Team:Data Management
masseyke
added
v7.17.7
v8.5.1
auto-backport-and-merge
This was referenced Sep 28, 2022
masseyke
added a commit
to masseyke/elasticsearch
that referenced
this pull request
Sep 28, 2022
Right now if watcher throws an exception while starting up (for example a TimeoutException while waiting for a refresh of .watches or .triggered_watches to complete) then watcher gets into a state where it will never be restarted automatically, and is incredibly difficult to start manually. This PR catches those exceptions and sets the state to STOPPED so that when the next cluster change event comes through it will attempt to start watcher again.
masseyke
added a commit
to masseyke/elasticsearch
that referenced
this pull request
Sep 28, 2022
Right now if watcher throws an exception while starting up (for example a TimeoutException while waiting for a refresh of .watches or .triggered_watches to complete) then watcher gets into a state where it will never be restarted automatically, and is incredibly difficult to start manually. This PR catches those exceptions and sets the state to STOPPED so that when the next cluster change event comes through it will attempt to start watcher again.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 28, 2022
Right now if watcher throws an exception while starting up (for example a TimeoutException while waiting for a refresh of .watches or .triggered_watches to complete) then watcher gets into a state where it will never be restarted automatically, and is incredibly difficult to start manually. This PR catches those exceptions and sets the state to STOPPED so that when the next cluster change event comes through it will attempt to start watcher again.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 28, 2022
Right now if watcher throws an exception while starting up (for example a TimeoutException while waiting for a refresh of .watches or .triggered_watches to complete) then watcher gets into a state where it will never be restarted automatically, and is incredibly difficult to start manually. This PR catches those exceptions and sets the state to STOPPED so that when the next cluster change event comes through it will attempt to start watcher again.
javanna
pushed a commit
to javanna/elasticsearch
that referenced
this pull request
Oct 4, 2022
Right now if watcher throws an exception while starting up (for example a TimeoutException while waiting for a refresh of .watches or .triggered_watches to complete) then watcher gets into a state where it will never be restarted automatically, and is incredibly difficult to start manually. This PR catches those exceptions and sets the state to STOPPED so that when the next cluster change event comes through it will attempt to start watcher again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now if watcher throws an exception while starting up (for example a TimeoutException while waiting for a refresh of
.watchesor.triggered_watchesto complete) then watcher gets into a state where it will never be restarted automatically, and is incredibly difficult to start manually. This PR catches those exceptions and sets the state to STOPPED so that when the next cluster change event comes through it will attempt to start watcher again.Closes #44981
Relates #69482