Added verbose option to segments api, with full ram tree as first additional element per segment
#9111
Conversation
|
I added docs with an example of how the output format looks in json. You can look at https://issues.apache.org/jira/browse/LUCENE-5949 for more examples of the information available. |
| writeRamTree(out, ramTree); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Maybe we can add a code comment about why these simple recursive impls are ok, since tree depth should be something tiny like 5 or 6.
There was a problem hiding this comment.
Sure, added a comment to writeRamTree
rjernst
added
:Data Management/Stats
|
We should be able to sync this with master now and remove even more code? Adrien upgraded lucene earlier today. |
|
There was an open pull request, but it was not merged yet. Now it's merged. |
rjernst
force-pushed
the
enhancement/mem-stats2
branch
from
c023282
to
33e135f
Compare
|
Ok, I synced up with latest master. |
|
LGTM |
|
|
||
| /** | ||
| * Sets the <code>verbose</code> option. | ||
| * @see {@link #verbose} |
There was a problem hiding this comment.
just for ref, im not sure this is really valid.
|
+1 from me too. Thanks Ryan! |
additional element per segment. This commit adds a verbose flag to the _segments api. Currently the only additional information returned when set to true is the full ram tree from lucene for each segment.
rjernst
force-pushed
the
enhancement/mem-stats2
branch
from
33e135f
to
f7f99b8
Compare
clintongormley
changed the title
option to segments api, with full ram tree as first additional element per segment
clintongormley
changed the title
option to segments api, with full ram tree as first additional element per segmentverbose option to segments api, with full ram tree as first additional element per segment
This commit adds a verbose flag to the _segments api. Currently the
only additional information returned when set to true is the full
ram tree from lucene for each segment.
Note: I added the ramTree as a public member on the
Segmentclass. This class has a mix of struct like members and some that have getters. It really should be cleaned up, but here I tried to follow what seemed like the most common pattern there.