add merge filters before building cluster filters (#55815) #91582
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently allocation filtering works only on delta settings. For example:
cluster.routing.allocation.exclude.zone
tous-east-1a
to allocate shards to all nodes not in zoneus-east-1a
.cluster.routing.allocation.exclude.rack
torack-id
. At this point, shards will relocate to nodes not in rackrack-id
, ignoring the zone tag which we first set.The reason for this bug is, when updating cluster settings for cluster
require/include/exclude
filters,AffixMapUpdateConsumer
is only passing setting deltas, thenFilterAllocationDecider
rebuilds new filters using the settings deltas.To fix this, we can merge the incoming
include/exclude/require
delta filters with the existing ones, and use the new merge filters to buildcluster include/exclude/require
filters. In this way, clusterrequire/include/exclude
filters will include all cluster settings we have set instead of the delta ones.ISSUE: #55815