Allow ILM step transition to the phase terminal step #91754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ILM tries to honour the cached phase however, some steps are implicit
(e.g. injected actions or the terminal policy/phase step)
Currently ILM would throw an exception if the currently cached phase
was removed:
```
step [{"phase":"warm","action":"complete","name":"complete"}] for index [index] with policy [my-policy] does not exist
```
This fixes this scenario allowing ILM to transition to the phase complete
step even if the phase has been removed from the actual policy.
andreidan
added
>bug
:Data Management/ILM+SLM
elasticsearchmachine
added
v8.7.0
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
Hi @andreidan, I've created a changelog YAML for you. |
andreidan
commented
Nov 21, 2022
Comment on lines
-593
to
-602
| Map<String, LifecycleAction> actions = new HashMap<>(); | ||
| actions.put(SetPriorityAction.NAME, new SetPriorityAction(100)); | ||
| Phase hotPhase = new Phase("hot", TimeValue.ZERO, actions); | ||
| Map<String, Phase> phases = Collections.singletonMap("hot", hotPhase); | ||
| LifecyclePolicy policyWithoutRollover = new LifecyclePolicy("my-policy", phases); | ||
| LifecyclePolicyMetadata policyMetadata = new LifecyclePolicyMetadata(policyWithoutRollover, Collections.emptyMap(), 2L, 2L); | ||
|
|
||
| ClusterState existingState = ClusterState.builder(ClusterState.EMPTY_STATE) | ||
| .metadata(Metadata.builder(Metadata.EMPTY_METADATA).put(meta, false).build()) | ||
| .build(); |
There was a problem hiding this comment.
These were unused
gmarouli
reviewed
Nov 21, 2022
| && (stepRegistry.stepExists(policyName, newStepKey) == false && newStepKey.equals(TerminalPolicyStep.KEY) == false)) { | ||
| && (stepRegistry.stepExists(policyName, newStepKey) == false | ||
| && newStepKey.equals(TerminalPolicyStep.KEY) == false | ||
| && newStepKey.equals(new Step.StepKey(lifecycleState.phase(), PhaseCompleteStep.NAME, PhaseCompleteStep.NAME)) == false)) { |
There was a problem hiding this comment.
Nit: The new here threw me off when I read it the first time. What do you think about adding a helper method in org.elasticsearch.xpack.core.ilm.PhaseCompleteStep:
- Either adding
boolean isFinalStep(StepKey stepKey), - or to add a final step key constructor:
public static StepKey stepKey(String phase) {
return new StepKey(phase, NAME, NAME);
}
gmarouli
approved these changes
Nov 21, 2022
|
@elasticmachine update branch |
|
@elasticmachine update branch |
joegallo
reviewed
Jan 4, 2023
x-pack/plugin/ilm/src/test/java/org/elasticsearch/xpack/ilm/IndexLifecycleTransitionTests.java
Show resolved
Hide resolved
|
@elasticmachine update branch |
andreidan
added
v8.7.1
auto-backport-and-merge
💔 Backport failed
You can use sqren/backport to manually backport by running |
andreidan
added a commit
to andreidan/elasticsearch
that referenced
this pull request
Mar 14, 2023
ILM tries to honour the cached phase however, some steps are implicit
(e.g. injected actions or the terminal policy/phase step)
Currently ILM would throw an exception if the currently cached phase
was removed:
```
step [{"phase":"warm","action":"complete","name":"complete"}] for index [index] with policy [my-policy] does not exist
```
This fixes this scenario allowing ILM to transition to the phase complete
step even if the phase has been removed from the actual policy.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 14, 2023
ILM tries to honour the cached phase however, some steps are implicit
(e.g. injected actions or the terminal policy/phase step)
Currently ILM would throw an exception if the currently cached phase
was removed:
```
step [{"phase":"warm","action":"complete","name":"complete"}] for index [index] with policy [my-policy] does not exist
```
This fixes this scenario allowing ILM to transition to the phase complete
step even if the phase has been removed from the actual policy.
andreidan
added a commit
to andreidan/elasticsearch
that referenced
this pull request
Mar 20, 2023
ILM tries to honour the cached phase however, some steps are implicit
(e.g. injected actions or the terminal policy/phase step)
Currently ILM would throw an exception if the currently cached phase
was removed:
```
step [{"phase":"warm","action":"complete","name":"complete"}] for index [index] with policy [my-policy] does not exist
```
This fixes this scenario allowing ILM to transition to the phase complete
step even if the phase has been removed from the actual policy.
(cherry picked from commit 3962556)
Signed-off-by: Andrei Dan <andrei.dan@elastic.co>
andreidan
added a commit
that referenced
this pull request
Mar 20, 2023
ILM tries to honour the cached phase however, some steps are implicit
(e.g. injected actions or the terminal policy/phase step)
Currently ILM would throw an exception if the currently cached phase
was removed:
```
step [{"phase":"warm","action":"complete","name":"complete"}] for index [index] with policy [my-policy] does not exist
```
This fixes this scenario allowing ILM to transition to the phase complete
step even if the phase has been removed from the actual policy.
(cherry picked from commit 3962556)
Signed-off-by: Andrei Dan <andrei.dan@elastic.co>
saarikabhasi
pushed a commit
to saarikabhasi/elasticsearch
that referenced
this pull request
Apr 10, 2023
ILM tries to honour the cached phase however, some steps are implicit
(e.g. injected actions or the terminal policy/phase step)
Currently ILM would throw an exception if the currently cached phase
was removed:
```
step [{"phase":"warm","action":"complete","name":"complete"}] for index [index] with policy [my-policy] does not exist
```
This fixes this scenario allowing ILM to transition to the phase complete
step even if the phase has been removed from the actual policy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ILM tries to honour the cached phase however, some steps are implicit (e.g. injected actions or the terminal policy/phase step) Currently ILM would throw an exception if the currently cached phase was removed:
This fixes this scenario allowing ILM to transition to the phase complete step even if the phase has been removed from the actual policy.
Part of #91749