Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align all usages of protobuf to be 3.21.9 #92123

Merged
merged 5 commits into from
Dec 7, 2022

Conversation

masseyke
Copy link
Member

@masseyke masseyke commented Dec 5, 2022

Upgrading to protobuf 3.21.9 everywhere. (copy of #91726)

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v8.7.0 labels Dec 5, 2022
@masseyke masseyke removed the needs:triage Requires assignment of a team area label label Dec 5, 2022
@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label Dec 5, 2022
@masseyke
Copy link
Member Author

masseyke commented Dec 5, 2022

I'm leaving protobuf-java-2.5.0.jar and hadoop-shaded-protobuf_3_7-1.1.1.jar in the verification metadata xml because they are used by the hdfs2-fixture, which we use to make sure we are backwards compatible with hdfs 2. They are test-only dependencies.

@masseyke
Copy link
Member Author

masseyke commented Dec 5, 2022

@elasticmachine run elasticsearch-ci/part-1

@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Dec 5, 2022
@elasticsearchmachine
Copy link
Collaborator

Hi @masseyke, I've created a changelog YAML for you.

@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Dec 5, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@masseyke masseyke removed :Data Management/Other Team:Data Management Meta label for data/management team labels Dec 5, 2022
@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label Dec 5, 2022
@masseyke masseyke added the :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs label Dec 5, 2022
@elasticsearchmachine elasticsearchmachine added Team:Distributed Meta label for distributed team and removed needs:triage Requires assignment of a team area label labels Dec 5, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@masseyke
Copy link
Member Author

masseyke commented Dec 5, 2022

@elasticmachine run elasticsearch-ci/docs-check

@masseyke
Copy link
Member Author

masseyke commented Dec 5, 2022

@elasticmachine run elasticsearch-ci/part-1

Copy link
Member

@jbaiera jbaiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If CI is all happy then I'm happy with this

@masseyke masseyke merged commit b8780d3 into elastic:main Dec 7, 2022
@masseyke masseyke deleted the upgrade_protobuf branch December 7, 2022 17:55
gwbrown pushed a commit to gwbrown/elasticsearch that referenced this pull request Apr 20, 2023
Updating repository-hdfs, repository-gcs, and vector-tile to all use the same more recent protobuf.

(cherry picked from commit b8780d3)

# Conflicts:
#	build-tools-internal/version.properties
#	gradle/verification-metadata.xml
#	plugins/repository-gcs/build.gradle
#	plugins/repository-hdfs/build.gradle
@gwbrown
Copy link
Contributor

gwbrown commented Apr 20, 2023

💚 All backports created successfully

Status Branch Result
7.17

Questions ?

Please refer to the Backport tool documentation

jakelandis added a commit that referenced this pull request Jan 9, 2024
This commit bumps the protobuf version for in 7.x to match the version used in main.
Main has been running this version since #92123
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed Meta label for distributed team >upgrade v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants