Access term dictionary more efficiently #92269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we sort all ids that are used in `mget` calls in lexicographically ascending order. As the term dictionary is also sorted lexicographically, we minimize the number of blocks that need to read, reducing page faults.
danielmitterdorfer
added
>enhancement
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
|
Hi @danielmitterdorfer, I've created a changelog YAML for you. |
|
Why not label also with |
|
heya @dnhatn I added you as a reviewer because I thought you have more context having recently done some work on mget performance. |
@rockdaboot this plugin will be released with 8.7.0, therefore this change can only be made available with 8.7.0 as well. |
dnhatn
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we sort all ids that are used in
mgetcalls inlexicographically ascending order. As the term dictionary (which is used to
lookup
_id) is also sorted lexicographically, we minimize the number ofblocks that need to read, reducing page faults.