[ML] Frequent items extension pruning #92322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @hendrikmuhs, I've created a changelog YAML for you. |
|
Pinging @elastic/ml-core (Team:ML) |
hendrikmuhs
force-pushed
the
frequent-items-extension-pruning-3
branch
from
959a1b2
to
cfd5f10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially machine-generated data contains data that always appears together, e.g. a URI and a path which is the same URI but without the protocol. Such a case is called an "extension". This PR implements so called extension pruning, it avoids iterating over those extensions to build all permutations of subsets from a superset. All with the same item counts.
This fixes problems with datasets based on APM and logging. For those a benchmark of the query execution time reduces from
19434198ms to103321ms (factor188).For more "natural" data sets like the ones used for rally-tracks this PR has no effect as pruning doesn't kick in here.