Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test examples for nori-analyzer #92336

Merged
merged 7 commits into from
Jan 11, 2023
Merged

Fix test examples for nori-analyzer #92336

merged 7 commits into from
Jan 11, 2023

Conversation

jso4342
Copy link
Contributor

@jso4342 jso4342 commented Dec 13, 2022 •
edited
Loading

C샤프 in English is C#, not C++.
(C++ in Korean is C플플, C쁠쁠 or C플러스플러스.)

It might be true that the writer used C샤프 as just an independent example, regardless C++, but I think it is better to align them for better understanding.

@github-actions
Copy link

Documentation preview:

@elasticsearchmachine elasticsearchmachine added v8.7.0 needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team labels Dec 13, 2022
@michaelbaamonde michaelbaamonde added the >docs General docs changes label Dec 15, 2022
@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team and removed needs:triage Requires assignment of a team area label labels Dec 15, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@michaelbaamonde michaelbaamonde added :Search/Analysis How text is split into tokens and removed >docs General docs changes labels Dec 15, 2022
@elasticsearchmachine elasticsearchmachine added Team:Search Meta label for search team and removed Team:Docs Meta label for docs team labels Dec 15, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@jso4342 jso4342 changed the title [DOCS] Fix typo Fix typo Dec 16, 2022
@javanna
Copy link
Member

javanna commented Dec 19, 2022

@elasticmachine test this please

@javanna javanna self-assigned this Dec 19, 2022
@javanna
Copy link
Member

javanna commented Dec 19, 2022

I ran tests and there seem to be relevant test failures. @jso4342 would you have time to a look at those?

@jso4342
Copy link
Contributor Author

jso4342 commented Dec 20, 2022

Sure, I'll have a look at it :) !

@javanna
Copy link
Member

javanna commented Dec 23, 2022

@elasticmachine retest this please

@jso4342
Copy link
Contributor Author

jso4342 commented Dec 24, 2022 •
edited
Loading

Hi @javanna early Merry Christmas!
I just switched C샤프 to C쁠쁠, instead of changing c++ to c# and it took off some testing failures.
But I still have a build failure with bwc test (only for v 7.17.8 tho).

Building 7.17.8 didn't generate expected artifact [distribution/bwc/maintenance/build/bwc/checkout-7.17/distribution/archives/linux-tar/build/install/elasticsearch-7.17.8-SNAPSHOT]. 
The working branch may be out-of-date - try merging in the latest upstream changes to the branch.

Perhaps it is because the branch is outdated?

@benwtrent
Copy link
Member

@elasticmachine update branch

@benwtrent
Copy link
Member

@elasticmachine retest this please

javanna
javanna approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests are green.

@javanna javanna merged commit e535df6 into elastic:main Jan 11, 2023
danielmitterdorfer pushed a commit to danielmitterdorfer/elasticsearch that referenced this pull request Jan 12, 2023
@jso4342 @danielmitterdorfer
Fix typo in nori docs and tests (elastic#92336)
4154482 
C샤프 in English is C#, not C++.
(C++ in Korean is C플플, C쁠쁠 or C플러스플러스.)

The translation doesn't make sense, so I changed C++ to C#.
It might be true that the writer used C샤프 as just an independent example, regardless C++, but I think it is better to align them for better understanding.
@jso4342 jso4342 changed the title Fix typo Fix examples for test Jan 15, 2023
@jso4342 jso4342 changed the title Fix examples for test Fix test examples for nori-analyzer Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javanna javanna javanna approved these changes

Assignees

@javanna javanna

Labels
external-contributor Pull request authored by a developer outside the Elasticsearch team >non-issue :Search/Analysis How text is split into tokens Team:Search Meta label for search team v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jso4342 @elasticsearchmachine @javanna @benwtrent @michaelbaamonde @elasticmachine