Speed up ingest geoip processors #92372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A cache hit is just a map lookup, there's nothing interesting about that SecurityManager-wise, so if we fold the check and doPrivileged calls into the inside of putIfAbsent then we only need to pay those costs on cache misses when we actually are going to do geoip database lookup work.
Since the release of com.maxmind.geoip2/geoip2 2.15.0, it doesn't seem that it uses jackson-databind anymore for these operations, so we no longer need additional permissions to run this code.
joegallo
added
>feature
:Data Management/Ingest Node
elasticsearchmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
Hi @joegallo, I've created a changelog YAML for you. |
|
For increased confidence with the sanity of this change, I've taken the trouble of downgrading geoip2 to 2.14.0 locally, and indeed everything blows up and gnashes its teeth and wails horribly about the lack of permissions and 17 tests fail. Re-upgrading from 2.14.0 to 2.15.0 results in all tests passing and no permissions issues. |
|
Hi @joegallo, I've updated the changelog YAML for you. Note that since this PR is labelled |
joegallo
added a commit
to joegallo/elasticsearch
that referenced
this pull request
Jan 13, 2023
This reverts commit 1c06ed8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were running the relatively expensive
SpecialPermission.check()/AccessController.doPrivileged(...)pair on every call to the cache, whether it was a cache hit or a cache miss. Inverting that code in my second commit made the expensive parts only run where absolutely needed (on cache misses).However, going still further, it turns out that in version 2.15.0 of the geoip library it stopped interacting with jackson-databind in a way that required us to have special permissions to begin with -- so we can drop the additional permissions from our policy file and we no longer need the
SpecialPermission.check()/AccessController.doPrivileged(...)pair for cache misses, either.In one of our nightly benchmarks, this speeds up
geoipprocessors by ~50%, but AFAICT those benchmarks use a less-cacheable random distribution of ip addresses -- I would expect the performance bump for real world use of the geoip processor to be even better than that.