Avoid needlessly forking for noop ReplicationTracker.createMissingPeerRecoveryRetentionLeases #92391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rRecoveryRetentionLeases Found while looking into overriding the replication tracker. Any override for stateless would make the adjusted method pointless in the override anyway. This operation is almost always a noop + we only use a single listener implementation -> simplify this thing to not consume a listener and avoid forking in most cases.
original-brownbear
added
>non-issue
:Distributed/CRUD
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
Jenkins run elasticsearch-ci/part-1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while looking into overriding the replication tracker. Any override for stateless would make the adjusted method pointless in the override anyway.
This operation is almost always a noop + we only use a single listener implementation -> simplify this thing to not consume a listener and avoid forking in most cases.
relates #92353