Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GA the Health API under the url /_health_report #92879

Merged
merged 5 commits into from
Jan 13, 2023

Conversation

gmarouli
Copy link
Contributor

@gmarouli gmarouli commented Jan 12, 2023

Because there was a path conflict we will rename the health API from _health to _health_report.

@github-actions
Copy link

Documentation preview:

@elasticsearchmachine
Copy link
Collaborator

Hi @gmarouli, I've created a changelog YAML for you.

@gmarouli gmarouli marked this pull request as ready for review January 12, 2023 16:59
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Jan 12, 2023
@gmarouli gmarouli changed the title Rename GET /_health to GET /_health_report GA the Health API under the endpoint /_health_report Jan 12, 2023
@gmarouli gmarouli changed the title GA the Health API under the endpoint /_health_report GA the Health API under the url /_health_report Jan 12, 2023
@gmarouli gmarouli added >feature and removed >bug labels Jan 12, 2023
dakrone added a commit to dakrone/elasticsearch that referenced this pull request Jan 12, 2023
This commits adds four "reserved" paths that Elasticsearch should not register under any cases. By registering these and returning a bad request (we don't *actually* serve them), we can ensure that if we ever try to register them in the path, Elasticsearch will trip an assertion and fail to build.

Must be merged *after* elastic#92879
dakrone added a commit to dakrone/elasticsearch that referenced this pull request Jan 12, 2023
This commits adds four "reserved" paths that Elasticsearch should not register under any cases. By registering these and returning a bad request (we don't *actually* serve them), we can ensure that if we ever try to register them in the path, Elasticsearch will trip an assertion and fail to build.

Must be merged *after* elastic#92879
Copy link
Contributor

@andreidan andreidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick fix.

Also, Health API 🚀

@gmarouli gmarouli merged commit a7fdd3c into elastic:main Jan 13, 2023
@gmarouli gmarouli deleted the health-api-rename-endpoint branch January 13, 2023 09:42
albertzaharovits pushed a commit to albertzaharovits/elasticsearch that referenced this pull request Jan 16, 2023
@gmarouli
Copy link
Contributor Author

gmarouli commented Feb 8, 2023

Relates to: #92209

@andreidan andreidan mentioned this pull request Feb 8, 2023
elasticsearchmachine pushed a commit that referenced this pull request Mar 4, 2024
The health report API changed names in
#92879, which causes this
YAML REST test to fail in versions < 8.7.0.

Closes #105923
nielsbauman added a commit to nielsbauman/elasticsearch that referenced this pull request Mar 4, 2024
The health report API changed names in
elastic#92879, which causes this
YAML REST test to fail in versions < 8.7.0.

Closes elastic#105923
elasticsearchmachine pushed a commit that referenced this pull request Mar 4, 2024
The health report API changed names in
#92879, which causes this
YAML REST test to fail in versions < 8.7.0.

Closes #105923
fang-xing-esql pushed a commit to fang-xing-esql/Elasticsearch that referenced this pull request Mar 8, 2024
The health report API changed names in
elastic#92879, which causes this
YAML REST test to fail in versions < 8.7.0.

Closes elastic#105923
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants