Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not refresh all indices in TransportBulkAction #93417

Merged
merged 3 commits into from
Feb 1, 2023
Merged

Do not refresh all indices in TransportBulkAction #93417

merged 3 commits into from
Feb 1, 2023

Conversation

tlrx
Copy link
Member

@tlrx tlrx commented Feb 1, 2023

Since we know which indices were involved in the Bulk request we can refresh only those instead of all indices.

Relates #93160

@tlrx tlrx added >bug :Distributed/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. v8.7.0 labels Feb 1, 2023
@elasticsearchmachine
Copy link
Collaborator

Hi @tlrx, I've created a changelog YAML for you.

@elasticsearchmachine elasticsearchmachine added the Team:Distributed Meta label for distributed team label Feb 1, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

DaveCTurner
DaveCTurner approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlrx
Copy link
Member Author

tlrx commented Feb 1, 2023 •
edited
Loading

Thanks David. Actually I think the refresh should also use indices options that expands to lenient open and hidden indices (otherwise hidden indices are not refreshed).

DaveCTurner
DaveCTurner approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LBTM (good -> better 😁 )

Do we have test coverage for this? We should add some if not.

@tlrx tlrx merged commit 2700dc5 into elastic:main Feb 1, 2023
@tlrx tlrx deleted the refresh-workaround-indices branch February 1, 2023 16:06
@tlrx
Copy link
Member Author

tlrx commented Feb 1, 2023

Thanks David. I'll add a test in a follow up.

jpountz pushed a commit to jpountz/elasticsearch that referenced this pull request Feb 2, 2023
@tlrx @jpountz
Do not refresh all indices in TransportBulkAction (elastic#93417)
e79098b 
Since we know which indices were involved in the Bulk 
request we can refresh only those instead of all indices, 
and expand to hidden indices so that they are also 
refreshed.

Relates elastic#93160
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaveCTurner DaveCTurner DaveCTurner approved these changes

Assignees
No one assigned
Labels
>bug :Distributed/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. Team:Distributed Meta label for distributed team v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tlrx @elasticsearchmachine @DaveCTurner