Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geo_grid ingest processor docs #93507

Merged

Conversation

craigtaverner
Copy link
Contributor

Docs for #93370

Which satisfies the requests in #92473

@craigtaverner craigtaverner added >docs General docs changes :Analytics/Geo Indexing, search aggregations of geo points and shapes Team:Docs Meta label for docs team Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Feb 6, 2023
@github-actions
Copy link

github-actions bot commented Feb 6, 2023

Documentation preview:

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

Copy link
Contributor

@abdonpijpelink abdonpijpelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a docs perspective. I've left some minor suggestions to avoid the words "we" and "above".

| `non_children_field` | no | - | If specified and intersecting non-child tiles exist, save their addresses to this field as an array of strings.
| `precision_field` | no | - | If specified, save the tile precision (zoom) as an integer to this field.
| `ignore_missing` | no | - | If `true` and `field` does not exist, the processor quietly exits without modifying the document.
| `target_format` | no | "GEOJSON" | Which format to save the generated polygon in. Either `WKT` or `GeoJSON`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this is case-insensitive, but maybe it would be good to be consistent between "GEOJSON" and GeoJSON?

docs/reference/ingest/processors/geo-grid.asciidoc Outdated Show resolved Hide resolved
docs/reference/ingest/processors/geo-grid.asciidoc Outdated Show resolved Hide resolved
docs/reference/ingest/processors/geo-grid.asciidoc Outdated Show resolved Hide resolved
docs/reference/ingest/processors/geo-grid.asciidoc Outdated Show resolved Hide resolved
docs/reference/ingest/processors/geo-grid.asciidoc Outdated Show resolved Hide resolved
docs/reference/ingest/processors/geo-grid.asciidoc Outdated Show resolved Hide resolved
docs/reference/ingest/processors/geo-grid.asciidoc Outdated Show resolved Hide resolved
docs/reference/ingest/processors/geo-grid.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@iverase iverase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nit: Could you change the title of the PR from Geo_tile to Geo_grid?

craigtaverner and others added 8 commits February 6, 2023 15:56
Co-authored-by: Abdon Pijpelink <abdon.pijpelink@elastic.co>
Co-authored-by: Abdon Pijpelink <abdon.pijpelink@elastic.co>
Co-authored-by: Abdon Pijpelink <abdon.pijpelink@elastic.co>
Co-authored-by: Abdon Pijpelink <abdon.pijpelink@elastic.co>
Co-authored-by: Abdon Pijpelink <abdon.pijpelink@elastic.co>
Co-authored-by: Abdon Pijpelink <abdon.pijpelink@elastic.co>
Co-authored-by: Abdon Pijpelink <abdon.pijpelink@elastic.co>
Co-authored-by: Abdon Pijpelink <abdon.pijpelink@elastic.co>
@craigtaverner craigtaverner changed the title Geo_tile ingest processor docs Geo_grid ingest processor docs Feb 6, 2023
@craigtaverner craigtaverner merged commit c18078e into elastic:main Feb 6, 2023
@craigtaverner craigtaverner deleted the geotile_ingest_processor_docs branch February 6, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >docs General docs changes Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Docs Meta label for docs team v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants