Porting watcher over to BulkProcessor2 #94133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @masseyke, I've created a changelog YAML for you. |
…ce writing to it is no longer synchronous
…g to history is now async
…/elasticsearch into using-bulkprocessor2-in-watcher
…ng to it is no longer synchronous
… since writing to it is no longer synchronous
… to it is no longer synchronous
…iting to it is no longer synchronous
…g to history is now async
|
@elasticmachine run elasticsearch-ci/part-1 |
…to it is no longer synchronous
…g to history is now async
elasticsearchmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
dakrone
approved these changes
Mar 1, 2023
This was referenced Mar 2, 2023
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 2, 2023
In #94133 we started loading watcher history asynchronously. I missed updating a test in HistoryIntegrationTests to wait for the history to be indexed. This fixes that.
saarikabhasi
pushed a commit
to saarikabhasi/elasticsearch
that referenced
this pull request
Apr 10, 2023
In elastic#91238 we rewrote BulkProcessor to avoid deadlock that had been seen in the IlmHistoryStore. This commit ports watcher over to the new BulkProcessor2 implementation. The only real change is that watcher history documents are now indexed asynchronously instead of in a blocking way, meaning that tests had to change to account for this.
saarikabhasi
pushed a commit
to saarikabhasi/elasticsearch
that referenced
this pull request
Apr 10, 2023
…lastic#94282) In elastic#94133 we started loading watcher history asynchronously. I missed updating DeleteWatchTests to wait for the history to be indexed. This fixes that.
saarikabhasi
pushed a commit
to saarikabhasi/elasticsearch
that referenced
this pull request
Apr 10, 2023
…4286) In elastic#94133 we started loading watcher history asynchronously. I missed updating a test in HistoryIntegrationTests to wait for the history to be indexed. This fixes that.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 27, 2023
…em (#95642) My theory is that the failure at #95077 was caused by #94133. It looks like the test is failing because the watcher history index exists, but not all shards have been allocated. Previously the bulk processor used to load watcher history was blocking. So if the watch completed you were guaranteed that the watcher history shards had been allocated because it didn't return until the watcher history documents had been written. The new bulk processor works asynchrnously, and doesn't block watcher. This change waits until the watcher history indices are green (all shards allocated) before querying them. Closes #95077
This was referenced May 8, 2023
ChrisHegarty
pushed a commit
that referenced
this pull request
Aug 9, 2023
In #94133 we started loading watcher history asynchronously. I missed updating a test in HistoryIntegrationTests to wait for the history to be indexed. This fixes that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #91238 we rewrote BulkProcessor to avoid deadlock that had been seen in the IlmHistoryStore. This PR ports watcher over to the new BulkProcessor2 implementation. The only real change is that watcher history documents are now indexed asynchronously instead of in a blocking way, meaning that tests had to change to account for this.