Remove commit information from refresh result #94259
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently made a change where the refresh result includes information about the current commit. However, this result is tightly tied to the concept of a flush. The refresh method in internal engine does not perform commits or flushes, so this result can be misleading to consumers. This commit extracts a separate method that will perform both a flush and a refresh and then returns the approriate generation.
Tim-Brooks
added
>non-issue
:Distributed/Engine
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
I ended up adjusting this just to read the commit stats after performing the refresh (and flush for index engine). I still feel like this is worth considering as I continue to prefer not tie the flush generation to the refresh result since they are not really related. Although if there are objections, we can discuss. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently made a change where the refresh result includes information about the current commit. However, this result is tightly tied to the concept of a flush. The refresh method in internal engine does not perform commits or flushes, so this result can be misleading to consumers. This commit just reads the flush generation from the commit stats.